Closed
Bug 962035
Opened 10 years ago
Closed 10 years ago
Remove html namespace in imbuddytooltip.xml
Categories
(Thunderbird :: Instant Messaging, defect)
Thunderbird
Instant Messaging
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 29.0
People
(Reporter: Paenglab, Assigned: Paenglab)
References
Details
Attachments
(1 file, 1 obsolete file)
2.27 KB,
patch
|
florian
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #956579 +++ As you are no longer using html namespace in imbuddytooltip.xml, then the xmlns:html could probably be removed: http://mxr.mozilla.org/comm-central/source/mail/components/im/content/imbuddytooltip.xml#12
Assignee | ||
Comment 1•10 years ago
|
||
This patch removes the html namespace.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8362913 -
Flags: review?(florian)
Comment 2•10 years ago
|
||
Comment on attachment 8362913 [details] [diff] [review] patch Thanks for cleaning this up. I would appreciate if you could also apply the same change to im/content/buddytooltip.xml (we are trying to keep these 2 files in sync; until we find a way to merge them).
Attachment #8362913 -
Flags: review?(florian) → review+
Assignee | ||
Comment 3•10 years ago
|
||
> Thanks for cleaning this up. I would appreciate if you could also apply the
> same change to im/content/buddytooltip.xml (we are trying to keep these 2
> files in sync; until we find a way to merge them).
Can I do this in this bug?
Assignee | ||
Comment 4•10 years ago
|
||
This removes the namespace on both files. If it's okay we can use this for check-in.
Attachment #8362958 -
Flags: review?(florian)
Comment 5•10 years ago
|
||
Comment on attachment 8362958 [details] [diff] [review] patch for both files Review of attachment 8362958 [details] [diff] [review]: ----------------------------------------------------------------- Excellent, thanks! :-)
Attachment #8362958 -
Flags: review?(florian) → review+
Updated•10 years ago
|
Attachment #8362913 -
Attachment is obsolete: true
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 6•10 years ago
|
||
https://hg.mozilla.org/comm-central/rev/b23556d66142
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 29.0
You need to log in
before you can comment on or make changes to this bug.
Description
•