Closed
Bug 962083
Opened 11 years ago
Closed 10 years ago
The footer of the identity panel should be a solid color and not a gradient
Categories
(Firefox :: Theme, defect)
Firefox
Theme
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: jaws, Unassigned, Mentored)
References
Details
(Keywords: ux-consistency, Whiteboard: [good first bug] [feature])
Attachments
(4 files, 1 obsolete file)
2.18 KB,
patch
|
ntim
:
feedback+
|
Details | Diff | Splinter Review |
9.01 KB,
patch
|
Details | Diff | Splinter Review | |
76.99 KB,
image/png
|
Details | |
140.00 KB,
image/png
|
Details |
Now that the panel background-color is white-ish, and the menu panel has a solid footer, we should make the identity panel also have a solid footer for internal consistency.
Reporter | ||
Updated•11 years ago
|
Keywords: ux-consistency
Updated•11 years ago
|
Whiteboard: [Australis:M?][Australis:P4] [feature] p=1
FWIW the mockup should an enhanced design for this : http://people.mozilla.org/~shorlander/mockups-interactive/australis-interactive-mockups/windows8.html
Updated•11 years ago
|
Whiteboard: [Australis:M?][Australis:P4] [feature] p=1 → [Australis:P4] [feature] p=1
Comment 2•11 years ago
|
||
Relevant parts of the code :
Windows : http://mxr.mozilla.org/mozilla-central/source/browser/themes/windows/browser.css#2114
Linux : http://mxr.mozilla.org/mozilla-central/source/browser/themes/linux/browser.css#1099
OSX : http://mxr.mozilla.org/mozilla-central/source/browser/themes/osx/browser.css#3370
Updated•11 years ago
|
OS: Windows 7 → All
Hardware: x86_64 → All
Comment 3•11 years ago
|
||
The goal is to make the identity popup footer look like the mockup in Comment 1. The relevant parts of the code are in Comment 2.
Mentor: ntim007
Points: --- → 1
Whiteboard: [Australis:P4] [feature] p=1 → [good first bug] [feature]
Comment 4•11 years ago
|
||
I have added solid color in place of gradient color in all the files(linux, mac and windows) and also added box-shadow.
Attachment #8477917 -
Flags: feedback?(ntim007)
Comment 5•11 years ago
|
||
Comment on attachment 8477917 [details] [diff] [review]
Patch (v1)
Review of attachment 8477917 [details] [diff] [review]:
-----------------------------------------------------------------
Since the box-shadow is just emulating the top border, I think you can use border-top instead.
Also, can you style the buttons like in the mockup as well please ? (I recommend doing that in a second patch, for less confusion to the peer reviewing it.
::: browser/themes/osx/browser.css
@@ +3342,1 @@
> border-top: 1px solid hsla(210,4%,10%,.12);
That means we now have 2 top borders on mac. I would use border-top: 1px solid rgba(24, 25, 26, 0.14); here (and do the same across platforms).
Attachment #8477917 -
Flags: feedback?(ntim007) → feedback+
Updated•11 years ago
|
Assignee: nobody → tusharaoljgd
Status: NEW → ASSIGNED
Comment 6•11 years ago
|
||
(In reply to Tim Nguyen [:ntim] from comment #5)
> Comment on attachment 8477917 [details] [diff] [review]
> Patch (v1)
>
> Review of attachment 8477917 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> Since the box-shadow is just emulating the top border, I think you can use
> border-top instead.
>
> Also, can you style the buttons like in the mockup as well please ? (I
> recommend doing that in a second patch, for less confusion to the peer
> reviewing it
Thank you Tim. I am going to take care of what you've said and I'll submit it in my next patch
>
> ::: browser/themes/osx/browser.css
> @@ +3342,1 @@
> > border-top: 1px solid hsla(210,4%,10%,.12);
>
> That means we now have 2 top borders on mac. I would use border-top: 1px
> solid rgba(24, 25, 26, 0.14); here (and do the same across platforms).
Comment 7•11 years ago
|
||
I don't want to take this bug, but I have a patch too. Maybe it can to help with buttons. %)
[Warning!] Tested on Linux only.
---
I replaced buttons with toolbarbuttons because:
a) For more consistency with another popups.
b) I can't find design spec for focused buttons.
Attachment #8481868 -
Flags: feedback?(ntim007)
Comment 8•11 years ago
|
||
Comment on attachment 8481868 [details] [diff] [review]
identity-popup-footer.patch
Review of attachment 8481868 [details] [diff] [review]:
-----------------------------------------------------------------
I'm not sure about changing the buttons into toolbarbuttons, it might be an a11y regression if they can't be focused anymore.
Attachment #8481868 -
Flags: feedback?(ntim007) → feedback?(jaws)
Comment 9•11 years ago
|
||
Comment on attachment 8481868 [details] [diff] [review]
identity-popup-footer.patch
(In reply to Alexander Seleznev from comment #7)
> I replaced buttons with toolbarbuttons because:
Please revert this.
Attachment #8481868 -
Flags: feedback?(jaws) → feedback-
Comment 10•11 years ago
|
||
TODO:
1. Test and fix (if needed) on Mac OS and Windows.
2. Add styles for focused buttons on Mac OS and Windows (need design?).
Attachment #8481868 -
Attachment is obsolete: true
Comment 11•11 years ago
|
||
Updated•11 years ago
|
Attachment #8481978 -
Flags: feedback?(mdeboer)
Comment 12•11 years ago
|
||
Comment on attachment 8481978 [details] [diff] [review]
identity-popup-footer-v2.patch
Review of attachment 8481978 [details] [diff] [review]:
-----------------------------------------------------------------
I think this is shaping up to look really great, thanks Alex!
However, I'm afraid this makes the 'More information...' button flex the entire width of the container (at least for me on OSX). You'll want to fix that before you can request review from someone.
Do you have an OSX, Linux and Windows machine at your disposal? That'd be very handy to test your work against all the major target platforms!
Attachment #8481978 -
Flags: feedback?(mdeboer)
Updated•11 years ago
|
Assignee: tusharaoljgd → seleznev.ru
Updated•11 years ago
|
Mentor: mdeboer
Comment 13•11 years ago
|
||
(In reply to Mike de Boer [:mikedeboer] from comment #12)
> this makes the 'More information...' button flex the entire width of the container
I have no idea what you meen. %) It doesn't look like on my screenshot from Linux?
> Do you have an OSX, Linux and Windows machine at your disposal?
Nope. Also, I just wanted to help Tushar Arora with this bug (not take it).
Updated•11 years ago
|
Assignee: seleznev.ru → tusharaoljgd
Updated•10 years ago
|
Assignee: tusharaoljgd → nobody
Updated•10 years ago
|
Status: ASSIGNED → NEW
Comment 14•10 years ago
|
||
After tinkering with the browser.css file of LINUX I got the result as attached
Comment 15•10 years ago
|
||
Comment 16•10 years ago
|
||
This has recently been fixed by the Control Center work.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•