96211 - javascript strict warnings in button.xml

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[Henrik Gemal]

Hyatt: again there are strict javascript warnings after you checkins! This time
after bug 94943.
Please make you you have "strict js warnings turned on" in Edit -> Prefs -> Debug

Opening a new window will produce:
Warning: redeclaration of var children
Source File: 
Line: 11, Column: 14
Source Code:
          var children = this.childNodes;
------
Warning: redeclaration of var i
Source File: 
Line: 12, Column: 19
Source Code:
          for (var i = 0; i < children.length; i++) {
-----------

Comment 1

[Henrik Gemal]

Attachment: patch to fix the annoying warnings!

Comment 2

[Henrik Gemal]

please dont future this one. All chrome pages with buttons on it (kind of all
files) will generate these warnings!

I've attached a patch that will fix the warnings. Anybody up for a r= and sr=?

Comment 3

[Brendan Eich [:brendan]]

Cc'ing folks.  I'll r or sr= as needed.  Hyatt and jag are ahead of me in line.

/be

Comment 4

[jag (Peter Annema)]

I'd like to see the declaration of |children| and |i| outside the two
loops. Call me old-fashioned :-) r=jag regardless.

Comment 5

[Henrik Gemal]

Attachment: better patch.

Comment 6

[David Hyatt]

--> jag

Comment 7

[Henrik Gemal]

Brendan: could you sr the latest patch?

Comment 8

[Brendan Eich [:brendan]]

sr=[e-mail] -- hyatt can check in!

/be

Comment 9

[Henrik Gemal]

Jag: please check in....

Someone plese tell Hyatt that he has to turn on strict javascript warnings...

Comment 10

[jag (Peter Annema)]

Henrik: it's that a= time again, and I'm not even gonna bother.

Comment 11

[Henrik Gemal]

the last statement I really really dont understand. These js warnings are 
flooding the console!

Comment 12

[Asa Dotzler [:asa]]

a=asa on behalf of drivers. 

Comment 13

[jag (Peter Annema)]

Checked in Aug 24.

Comment 14

[Henrik Gemal]

Verified fixed in 20020115. Will reopen if I see these warnings again...