962120 - [CostControl] Once insert valid PIN I can't see "cost control" application open

Status: RESOLVED DUPLICATE of bug 963682

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Loli (:lolimartinezcr)]

Build master 01/16/14
BuildID: 20140116105426
Platform version: 29.0a1
Git commit info: b6784673

Pre-requisites:
SIM car with PIN but not inserted.

Step:
1. Tap Cost control aplication 
2. Insert valid PIN number.
3. Press OK button. 

Actual result:
Show "Locked SIM card. Unlock your SIM to enable Usage."

Expected result:
Usage aplication open.

Comment 1

[Marina Rodríguez [:mai]]

Attachment: patch v1.0

On this approach, if the simcard is locked, the application checks again the cardState of the SIM when the user press the button "ok" on "Locked SIM card" message window. In case of the user enter a valid PIN code, the application doesn't close.

IMHO we have to change the message "Locked SIM card. Unlock your SIM to enable Usage", to something more ambigous. (e.g. "Usage application needs the SIM card is not locked")

WDYT?
Regards

Comment 2

[Salvador de la Puente González [:salva]]

Comment on attachment 8363673 [details] [review]
patch v1.0

The solution involves unnecessary actors, see my comments on GitHub.

I agree on you the comment should be more general. Explain why and put a ni? to UX. Thank you :)

Comment 3

[Marina Rodríguez [:mai]]

Hi,
The application normal behaviour when the SIM is locked and the user launchs the application, is the following:
  1. Costcontrol application display the following message "Locked SIM card. Unlock your SIM to enable   Usage".
  2. When the user presses the button "OK" the application is closed.

Right now, the system process launchs automatically a screen to enter pin code overlapping the screen message ("Locked SIM card. Unlock your SIM to enable Usage"). This produces two scenarios:
  1. The user press button "Skip", the simcard continues locked, and the user reads the message: "Locked SIM card. Unlock your SIM to enable Usage". (This is correct)
  2. The user unlocks the SIM, when the "enter pin screen" is closed the user reads the message: "Locked SIM card. Unlock your SIM to enable Usage". (This is an error because the simcard is unlocked)
The second scenario is rare or confused for the user, because the sim is already unlocked.

IMHO we have to change the message "Locked SIM card. Unlock your SIM to enable Usage", to something more ambigous. (e.g. "Usage application needs the SIM card is not locked") valid for both scenarios.

WDYT?

Comment 4

[Harly Hsu[:harly]]

Redirect needinfo to Ayman as he will be taking care of cost control.

Comment 5

[Marina Rodríguez [:mai]]

Attachment: Current application behavior

Ayman, I attach the video showing the current application behaviour, that you asked to me

Comment 6

[ayman maat :maat]

hi Marina

Thanks for the video clarifying the situation. I think there are a couple of points here:

1) I believe the problem you are detailing is more of a system level issue than an app level issue. When an app requires a PIN in order to open the explanation that the app requires a PIN should be given at the system level, not by the app itself. This would prevent the enter PIN dialogue overlaying the notification of PIN requirement - which is the root of this bug.

2) I am not certain why we are preventing the user from accessing the Cost Control app by requesting a PIN number. The app also records WIFI usage which does not require a SIM card so the user should be able to access that functionality / facility without the SIM being active. I would therefore recommend that we requested a PIN code at a much lower level in the app at the point that Mobile usage is access… but we can tackle that  in another bug

Due to time constraints I would recommend that, for a quick win, we simply remove the dialogue that states "Locked SIM card. Unlock your SIM to enable Usage." which would leave just the enter SIM PIN dialogue for the user to interact with before accessing the app.

ni? me if you require any further input or clarification