Arrow panel box-shadow is cut off at the bottom and right side

RESOLVED FIXED in mozilla29

Status

()

Toolkit
Themes
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

({polish, regression})

Trunk
mozilla29
All
Windows 7
polish, regression
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Australis:M?][Australis:P3][good first verify])

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
Created attachment 8363073 [details]
screenshot (contrast enhanced)

Bug 859751 changed the box-shadow's position and blur radius, causing the shadow not to fit into the space that's reserved for it.
Blocks: 950073
Whiteboard: [Australis:M?][Australis:P5] [feature] p=2
(Assignee)

Comment 1

5 years ago
FWIW, I only tweaked the screenshot to make it more obvious what I was talking about. I actually saw this with the naked eye. This looks pretty unprofessional. We should just revert to the previous box-shadow until we have something better.
Assignee: nobody → dao
Whiteboard: [Australis:M?][Australis:P5] [feature] p=2 → [Australis:M?][Australis:P3] [feature] p=2
(Assignee)

Comment 2

5 years ago
Created attachment 8363704 [details] [diff] [review]
patch

This reverts the position and blur radius to what we had before but keeps the new color.
Attachment #8363704 - Flags: review?(mdeboer)
Comment on attachment 8363704 [details] [diff] [review]
patch

Review of attachment 8363704 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. One question, just in case the answer is not to make the drop-shadow at least visible to the user: why the opacity of .2?
Attachment #8363704 - Flags: review?(mdeboer) → review+
(Assignee)

Comment 4

5 years ago
(In reply to Mike de Boer [:mikedeboer] from comment #3)
> Comment on attachment 8363704 [details] [diff] [review]
> patch
> 
> Review of attachment 8363704 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks good to me. One question, just in case the answer is not to make the
> drop-shadow at least visible to the user: why the opacity of .2?

It matches the opacity of the border color, just like they matched before bug 859751. Also, I'm replacing two box-shadows with an opacity of 10%, i.e. roughly 20% in aggregate.
https://hg.mozilla.org/mozilla-central/rev/36d68b6e3bf6
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29

Updated

4 years ago
No longer blocks: 950073
Whiteboard: [Australis:M?][Australis:P3] [feature] p=2 → [Australis:M?][Australis:P3]

Updated

4 years ago
Whiteboard: [Australis:M?][Australis:P3] → [Australis:M?][Australis:P3][good first verify]
You need to log in before you can comment on or make changes to this bug.