962169 - Should be able to specify a "default" set of actions for web tests that apply across all devices

Status: RESOLVED FIXED

(Testing Graveyard :: Eideticker, defect)

Description

[William Lachance (:wlach)]

Right now we need to specify a set of actions for each device we want to use with web tests, which is ridiculous with things like the clock or my new "canvas box" test where the only action we want to take is sleep for 5 seconds.

Comment 1

[William Lachance (:wlach)]

Attachment: Allow specifying a set of default actions for web tests;r=davehunt

Comment 2

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8363178 [details] [diff] [review]
Allow specifying a set of default actions for web tests;r=davehunt

Review of attachment 8363178 [details] [diff] [review]:
-----------------------------------------------------------------

I'm unable to test this as I've bricked my device, but the patch looks good. Should we add the default actions where appropriate - such as for the clock test - in the same patch?

Comment 3

[William Lachance (:wlach)]

Pushed: https://github.com/mozilla/eideticker/commit/3bba5bc2d920911af112a0e5296578af030cf1c1

(In reply to Dave Hunt (:davehunt) from comment #2)
> Comment on attachment 8363178 [details] [diff] [review]
> Allow specifying a set of default actions for web tests;r=davehunt
> 
> Review of attachment 8363178 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I'm unable to test this as I've bricked my device, but the patch looks good.
> Should we add the default actions where appropriate - such as for the clock
> test - in the same patch?

The clock test is actually in a seperate module (ep1) but I will update that with this default. I don't think there's a pressing need to update any of the other tests as the required logic there is still somewhat device specific.