962177 - Gaia build fails if distribution apps have a .git

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Diego Wilson [:diego]]

Gaia allows vendors to install custom apps via an apps.list file in the GAIA_DISTRIBUTION_DIR.

Recently apps of this kind that are in git source control started failing with this message:

Exception: Error: Can't add inexistent file to zip : /local/mnt/buildbot/tip_b2g_jb_3_3/build/gaia/outoftree_apps/apitest/.git/svn
addToZip@resource://gre/modules/commonjs/toolkit/loader.js -> file:///local/mnt/buildbot/tip_b2g_jb_3_3/build/gaia/build/webapp-zip.js:143
execute/</<@resource://gre/modules/commonjs/toolkit/loader.js -> file:///local/mnt/buildbot/tip_b2g_jb_3_3/build/gaia/build/webapp-zip.js:350
execute/<@resource://gre/modules/commonjs/toolkit/loader.js -> file:///local/mnt/buildbot/tip_b2g_jb_3_3/build/gaia/build/webapp-zip.js:346
makeWebappsObject/<.forEach/<@resource://gre/modules/commonjs/toolkit/loader.js -> file:///local/mnt/buildbot/tip_b2g_jb_3_3/build/gaia/build/utils-xpc.js:247
makeWebappsObject/<.forEach@resource://gre/modules/commonjs/toolkit/loader.js -> file:///local/mnt/buildbot/tip_b2g_jb_3_3/build/gaia/build/utils-xpc.js:187
execute@resource://gre/modules/commonjs/toolkit/loader.js -> file:///local/mnt/buildbot/tip_b2g_jb_3_3/build/gaia/build/webapp-zip.js:317
@-e:1
make[1]: *** [webapp-zip] Error 3
make[1]: Leaving directory `/local/mnt/buildbot/tip_b2g_jb_3_3/build/gaia'
make: *** [gaia/profile.tar.gz] Error 2
make: *** Waiting for unfinished jobs...

Comment 1

[Diego Wilson [:diego]]

hub,

I noticed you made several changes within the past week to gaia/Makefile. Could one of these changes have caused this?

Comment 2

[Hubert Figuiere [:hub]]

I don't think so. My changes are only to run the test.

Comment 3

[Hubert Figuiere [:hub]]

Maybe you should look at revision 3eb52bf51d1ce57cdbbf9ee8cade488d77985ef1 that changed various build script.

Comment 4

[Michael Vines [:m1] [:evilmachines]]

Attachment: Avoid packing .git/ into webapps on master

Comment 5

[Hubert Figuiere [:hub]]

Comment on attachment 8378518 [details] [review]
Avoid packing .git/ into webapps on master

This is not my area at all. Picking a better reviewer (I think).

Comment 6

[Michael Vines [:m1] [:evilmachines]]

Thanks :hub

Comment 7

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8378518 [details] [review]
Avoid packing .git/ into webapps on master

looks good, thank you :-)

Comment 8

[Michael Vines [:m1] [:evilmachines]]

https://github.com/mozilla-b2g/gaia/commit/2f521fe27d420deb55e884d2353163d9e8f3827c