962189 - Endianness of AppFeature Bits

Status: RESOLVED INVALID

(Marketplace Graveyard :: Code Quality, defect, P4)

Description

[Mark Striemer [:mstriemer]]

New features are added to the AppFeature bit mask as the least-significant bit. This causes the bit numbers to change for each feature when we add new features and the resulting int value to change for the same feature set across versions.

Perhaps the new features should be added as the most-significant bit.

Comment 1

[Mark Striemer [:mstriemer]]

Purple is clearly the right colour. I think this should change so that old feature bit masks don't need to change when we start supporting new features. If an app has a feature int value of 34 then supporting new features on Marketplace shouldn't change it, only changing the feature set the app requires should change the int value.

Comment 2

[Wil Clouser [:clouserw]]

What does this bug consist of?  Just changing the documentation to say "append" instead of "prepend" or is there code to write?  Trying to get a feel for how long it would take.

Comment 3

[Mark Striemer [:mstriemer]]

I don't think there should be code to change, we can just start putting new features on the top of the list.

Comment 4

[Wil Clouser [:clouserw]]

So...what is this bug then? :)

Comment 5

[Rob Hudson [:robhudson]]

Closing as I think this was just documentation confusion. Reopen if I'm wrong.