962191 - [stage] Legacy groups should accept new members

Status: VERIFIED FIXED

(Participation Infrastructure :: Phonebook, defect)

Description

[Justin Crawford [:hoosteeno] [:jcrawford]]

Steps to replicate:
1. Visit a legacy group (such as "Beer and Tell" https://mozillians.allizom.org/en-US/group/beer-and-tell/) as a non-admin user
2. Join the group
3. See the "Your request is pending" message

Expected:
I can join a group that was present before this feature landed. "Accepting New Members" should be set to "Yes".

Actual: 
My request is pending and there is no curator to respond to it. "Accepting New Members" is set to "By Request"

Comment 1

[Dan Poirier [:dpoirier]]

I think we can fix this with a migration that finds all groups that are not functional areas or system groups and don't have curators, and changes their "Accepting New Members" value to "Yes".

Might be a good mentored bug.

Comment 2

[Justin Crawford [:hoosteeno] [:jcrawford]]

This is blocking launch. :dpoirier, can you take it on?

Comment 3

[Andrei Hajdukewycz [:sancus]]

I got this.

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/c38dce8705fc52c05182ba511457e4c604f9e478
[Fix Bug 962191] Migrate groups without a curator to accept new members

https://github.com/mozilla/mozillians/commit/60480a2f6ef4a10c0c1a7d4d1e012d73e40173cc
Merge pull request #786 from Sancus/legacygroups

[Fix Bug 962191] Migrate groups without a curator to accept new members

Comment 5

[Justin Crawford [:hoosteeno] [:jcrawford]]

I just joined a ton of groups in stage. While I can't say that every legacy group is now accepting members, I can say that every legacy group I joined was.

Verified.

Comment 6

[Justin Crawford [:hoosteeno] [:jcrawford]]

Attachment: screenshot showing the groups I joined to verify this bug