Shorthand from IRC: [12:33:51] <jakem> cmore: so, the change on bedrock's end is that the name of the product changes when delivering a full installer [12:33:58] <jakem> it gets "-SSL" appended to it [12:34:07] <jakem> but only on full installer... stub doesn't change [12:34:15] <jakem> and at the moment, only on release channel Longhand: We've added new products in Bouncer for SSL delivery of full installers. Example: curl -v 'https://download.mozilla.org/?product=Firefox-26.0-SSL&os=win&lang=en-US' ... < Location: https://download-installer.cdn.mozilla.net/pub/firefox/releases/26.0/win32/en-US/Firefox%20Setup%2026.0.exe Note the "-SSL" in the product name. This product (Firefox-26.0-SSL) was created manually in bug 956677. There is also bug 956674 to see about doing this automatically as part of the automation, but we needn't block on that to start using this. Bedrock should be changed to direct users to the "-SSL" version of the product whenever downloading a full installer on the release channel. For the moment, beta is not affected. Stub installer will never be affected by this (as stub installer is always served over SSL). The reason for this particular implementation is that Stub installer itself should not fetch the installer over SSL. That means it needs to be possible to deliver the full installers over both SSL (for users who download the full installer directly, like on OSX or Linux) and over non-SSL (for stub installer). This chosen solution is simpler to implement and more foolproof than guessing at which to serve based on arguments or UA strings, which are the only realistic alternatives. This change definitely needs to be tested. We'll want to deploy to dev/stage and have the mainline QA folks run through it and make sure they can download and install Firefox release and beta from both full and stub installers after this change, from www.allizom.org. Hopefully I've covered everything. Please let me know if any details are unclear. Thank you!
We can probably add this product logic here: https://github.com/mozilla/bedrock/blob/master/bedrock/firefox/firefox_details.py
I'll update the bouncer tests to check for the *SSL.
Assignee: nobody → kohei.yoshino
Status: NEW → ASSIGNED
What's the status here?
The pull request still needs a test and review.
27 is about to be released. Is that going to break anything here? (I'm thinking, if the product-details get bumped and the download links get changed, but the new products for SSL aren't created yet for 27.) I'm just being extra cautious...
Firefox 27 won't break anything. Versions forced SSL can be maintained manually. Currently only 26.0 is listed (but the pull request is still waiting for a review), and 27.0 can be added to the list once the bouncer is ready. https://github.com/mozilla/bedrock/pull/1603/files#diff-4
I have updated the pull request, still in the review queue, for 27.0 while waiting for the Firefox-27.0-SSL product.
What's the ETA here?
Commits pushed to master at https://github.com/mozilla/bedrock https://github.com/mozilla/bedrock/commit/9beb17aba1fbd25bd062255be281501158878410 Fix Bug 962204 - change Firefox download links to reference SSL products in bouncer https://github.com/mozilla/bedrock/commit/0602e6654bbfa41de319916eb5f4f61452e82dd9 Merge pull request #1603 from kyoshino/bug-962204-download-ssl Fix Bug 962204 - change Firefox download links to reference SSL products in bouncer
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Sorry for the delay. My pull request has just been reviewed and pushed to master/dev, will be pushed to production later today. https://www-dev.allizom.org/en-US/firefox/new/
Looks like there was no push today. Hopefully tomorrow.
There was no push today again... People might be busy. And looks like 27.0.1 is coming this Friday. I'll update the SSL-enabled version list.
Mike: When is the next push and when will this go out?
Commits pushed to master at https://github.com/mozilla/bedrock https://github.com/mozilla/bedrock/commit/d5be110ebc5a238801ac35fc79e57bc368719ebb Bug 962204, update the SSL-enabled product list for Firefox 27.0.1 The new version is coming this Friday. https://github.com/mozilla/bedrock/commit/10fb48528d6722f8904961419ce2f75518db45c5 Merge pull request #1692 from kyoshino/bug-962204-download-ssl-2701 Bug 962204, update the SSL-enabled product list for Firefox 27.0.1
I'd be happy to push tomorrow morning, unless pmac beats me to it. :)
This was pushed to production on 2014-02-13 and the download button on https://www.mozilla.org/en-US/firefox/new/ currently points to https://download.mozilla.org/?product=firefox-27.0.1-SSL&os=linux&lang=en-US for me (from chromium-- naturally it doesn't show up on my firefox :)
You need to log in before you can comment on or make changes to this bug.