962215 - [B2G][Contacts]Unable to import contacts from the SD card.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Andrew Stole [:astole]]

Attachment: Video

User is unable to import six or more contacts from the SD card.

Repro Steps:
1) Updated Buri to BuildID: 20140121040201
2) Make sure SD card has six or more contacts
3) Open Contacts and go to 'Settings'
4) Select 'Import Contacts'
5) Select 'Memory Card'

Actual:
The user gets stuck importing the contacts and is unable to select cancel.

Expected:
User can import all contacts from the SD card.

Environmental Variables:
Device: Buri v1.4 Master Build, Mozilla RIL
BuildID: 20140121040201
Gaia: e218d17ae7d01a81d48f833cd6fafb4e11b26cd8
Gecko: cdc0ab2c0cba
Version: 29.0a1
Firmware Version: V1.2-device.cfg

Repro frequency: 3/3 devices, 100%
See attached: Video, logcat

Comment 1

[Andrew Stole [:astole]]

Attachment: logcat

Comment 2

[Andrew Stole [:astole]]

Attachment: 21_1_2014_5.vcf

Comment 3

[Andrew Stole [:astole]]

It appears the issue is slightly different then the original description. After looking at the vcf file, it appears that there were originally only five contacts on the SD card, but the phone is attempting to import six so it gets stuck after five contacts. The video example shows the same issue with trying to import 11 contacts when there were only ten on the SD card.

Update to Repro step 2:
2) Make sure SD card has five or more contacts

This issue does not occur on v1.3

Environmental Variables:
Device: Buri v1.3 Mozilla RIL
BuildID: 20140121004137
Gaia: 47049555282a9a01fb60d1e1421b57e2810c96f5
Gecko: 6f7dfe36ab6c
Version: 28.0a2
Firmware Version: V1.2-device.cfg

Comment 4

[Marcia Knous [:marcia]]

Andrew: I have an SD Card that has 250 vcf contacts and did not see this issue? Can you recheck with another file to see if you still reproduce?

Comment 5

[Andrew Stole [:astole]]

Checked it on four different devices, all with different SD Cards, and it occurred on all of them. Most contacts that were used was 150.

Comment 6

[Noemí Freire (:noemi)]

Attachment: Bug962215_v1.3.txt

Hi,

I'm able to reproduce the issue "User is unable to import six or more contacts from the SD card" with v1.3

STRs:
1) Updated Buri to BuildId: 2014012206556
2) SD card has six contacts
3) Open Contacts and go to 'Gear' icon
4) Select 'Import Contacts'
5) Select 'Memory Card'

Actual:
The user gets stuck importing the contacts and is unable to select cancel.

Environmental Variables:
Device: Buri v1.3, Mozilla RIL
BuildId: 2014012206556
Gecko: 6840e8c
Gaia: 744fb69
Version: 28.0a2

Repro frequency: 100%
See also attached vcf file

Comment 7

[Noemí Freire (:noemi)]

Attachment: 22_1_2014_6.vcf

vcf file used for reproducing the issue under v1.3 branch.

Comment 8

[Noemí Freire (:noemi)]

Per comment 6 marking 'status-b2g-v1.3' flag as affected and 'blocking-b2g' as v1.3?

Comment 9

[Jason Smith [:jsmith]]

(In reply to Noemí Freire (:noemi) from comment #8)
> Per comment 6 marking 'status-b2g-v1.3' flag as affected and 'blocking-b2g'
> as v1.3?

I'm wondering if the bug you are seeing here is the same or different than the bug found here.

Can someone test with each vcf file here to check reproducibility on 1.3? If the reproducibility is different, then we have different bugs here.

Comment 10

[sarsenyev]

I couldn't reproduce it on 1.3
After trying a couple builds, I used each vcf attached file, but I couldn't reproduce it on 1.3, the contacts are imported successfully every time
However it does reproduce on 1.4, looking for a regression window

Comment 11

[sarsenyev]

Attachment: VideoBug.ogg

I noticed on some working builds, the number of imported contacts more than are shown on the importing contacts screen, for more details see the attached video

Last working build when all contacts from memory card are imported
Device: Buri 1.4 MOZ
BuildID: 20140120040203
Gaia: cf19095a08e1279667b3af0df920c0b0107c8cad
Gecko: 73bd4c0f880e
Version: 29.0a1
Firmware Version: v1.2-device.cfg

The first broken build when importing contacts process stuck 
Device: Buri 1.4 MOZ
BuildID: 20140121040201
Gaia: e218d17ae7d01a81d48f833cd6fafb4e11b26cd8
Gecko: cdc0ab2c0cba
Version: 29.0a1
RIL Version: 01.02.00.019.102
Firmware Version v1.2-device.cfg

Comment 12

[Maria Angeles Oteo (:oteo)]

Attachment: logcat.txt

Comment 13

[Maria Angeles Oteo (:oteo)]

Attachment: 23_1_2014_6.vcf

I am reproducing the error in latest v1.3 buri build trying to import 6 contacts from a SD card. 
Logcat included in #comment 12

Environmental Variables:
Device: Buri v1.3, Qualcom RIL
BuildId: 20140123065710
Gecko: 086e699
Gaia: 6fbeac2
Version: 28.0a2

Repro frequency: 100%

Comment 14

[Jason Smith [:jsmith]]

(In reply to Maria Angeles Oteo (:oteo) from comment #13)
> Created attachment 8364333 [details]
> 23_1_2014_6.vcf
> 
> 
> I am reproducing the error in latest v1.3 buri build trying to import 6
> contacts from a SD card. 
> Logcat included in #comment 12
> 
> Environmental Variables:
> Device: Buri v1.3, Qualcom RIL
> BuildId: 20140123065710
> Gecko: 086e699
> Gaia: 6fbeac2
> Version: 28.0a2
> 
> Repro frequency: 100%

So QC RIL can't be trusted here for testing - they no longer issue updated builds out to us, so we don't know if this is actually valid. This needs to be confirmed on a Moz RIL build.

Comment 15

[sarsenyev]

As per comment 13, I am confirming the issue reproduce on the latest today's 1.3 MOZ RIL build.
With this latest attachment "23_1_2014_6.vcf" the importing process stuck on all 1.4 builds.
I tried some other vcf files, the importing doesn't stuck on previous builds on 1.3 until today, 
But the importing issues appear on previous 1.3 builds as well with this "23_1_2014_6.vcf" attachment
The previous regression window was based on the previously attached filed and my own contacts, but with this latest vcf attachement it's not easy to get a regression window, because of getting different results with different vcf files 

Device: Buri 1.3 MOZ
BuildID: 20140123004001
Gaia: 6fbeac2415f07f10de181f0877ddf67ee299b885
Gecko: e8f6bdf8db3d
Version: 28.0a2
Firmware Version: v1.2-device.cfg

Comment 16

[Jason Smith [:jsmith]]

I need better clarity here on comment 15.

With each vcf file attached in this bug, does this issue reproduce on 1.3 or not? I'm looking to understand if there's different bugs here or not.

Comment 17

[sarsenyev]

The issue does reproduce on the latest 1.3 MOZ RIL build

21_1_2014_5.vcf- for 1.3 reproduces only today's build, for 1.4 reproduces from 1/21
22_1_2014 6.vcf- for 1.3 reproduces only today's build, for 1.4 reproduces from 1/21
23_1_2014 6.vcf- for 1.3 reproduce on the latest and previous builds, for 1.4 issue reproducible 100% from 1/21 but also sometimes on the earlier 1.4 builds, but not on all devices and not 100% reproducible

Comment 18

[Francisco Jordano [:arcturus] [:francisco]]

I can reproduce it in 1.3 as well.


Seems to me as a bug in the throttling mechanism, it fails when importing 5 contacts that is what we read in memory before saving it as a block.

Pinging Sergi for more info

Comment 19

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: Pointer to PR 15656

Sergi can you review the patch?

Comment 20

[Preeti Raghunath(:Preeti)]

1.3+ per triage for DSDS

Comment 21

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8364561 [details] [review]
Pointer to PR 15656

Changing reviewer to have this in time frame for closing 1.3 ;)

Comment 22

[Jose Manuel Cantera]

Comment on attachment 8364561 [details] [review]
Pointer to PR 15656

thanks!

Comment 23

[Francisco Jordano [:arcturus] [:francisco]]

Landed:

https://github.com/mozilla-b2g/gaia/commit/994bf56beaa04bb63a5a0448a0a82ac93f399502

Comment 24

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 994bf56beaa04bb63a5a0448a0a82ac93f399502 to:
v1.3: 443b07588116a34a9b7901882c98d29df2cea06f

Comment 25

[Loli (:lolimartinezcr)]

Tested (02/03/2014) and WORKING
1.3
Gecko e01ea79
Gaia f9a37c7