962286 - activeWindow "isFocused" or "isForeground" attribute.

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P3)

Description

[Gregg Lind (Fx Strategy and Insights - Shield - Heartbeat )]

Rare case, but sometimes knowing if 'firefox' is the focused window is useful.

(notifications, other ui bits)

I have a small implementation, but it's hard to test as part of another addon, and it would be nice to roll it into core, if people think it's useful.  

If so:

- thoughts on name (foreground?  active?)
- my hack relies on getOuterId and such, but I think I can get around that.
- what should semantics be around private? I am assuming the same as for 'activeWindow'?

Comment 1

[Gregg Lind (Fx Strategy and Insights - Shield - Heartbeat )]

Closest I got: 

https://github.com/gregglind/hotdish/commit/3f966a1c28108835c8528097bc9eec74aae16291

Hard one to test.

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

P3, and patches welcome. ;)

Comment 3

[Gregg Lind (Fx Strategy and Insights - Shield - Heartbeat )]

wes, have opinions on the vibe of it (before I get working on it)?  

I plan to expose something like "getForegroundWindow -> sdkWindow" (in 'browserWindows') and "isForeground -> bool" on any sdk window.

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I got nothing. Maybe Irakli has some ideas?

Comment 5

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Gregg, I feel like you maybe complicating things here a little, it should be easy to
implement isFocused(window):

const { viewFor } = require("sdk/view/core");
const focusManager = Cc["@mozilla.org/focus-manager;1"].getService(Ci.nsIFocusManager);
const isFocused = window => focusManager.activeWindow === viewFor(window);

I don't mind exposing `isFocused` getter on window instance as well.

As of `getForegroundWindow` I don't see what's the purpose, since `browserWindows.activeWindow` is
that unless non browser window has a focus, for which there's no SDK analogues.

Comment 6

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1612

Comment 7

[Matteo Ferretti [:zer0] [:matteo]]

Comment on attachment 8484150 [details] [review]
Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1612

I wasn't sure if r+ with the comments addressed or r- because the comments; I think it's probably better just have a quick glance before commit after the comments are addressed – or discussed, if I misunderstood something.

Comment 8

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/14a5932642b834fbea88bde3baa3cd5e2aaf95a5
Bug 962286 making sdk/window/utils isFocused export a dispatcher which now works for high level windows

https://github.com/mozilla/addon-sdk/commit/95a2f2548a8968d70e4441858670aed204e2229f
Merge pull request #1612 from erikvold/962286

Bug 962286 making sdk/window/utils isFocused export a dispatcher which now works for high level windows r=@ZER0