962327 - Update when reusing existing bug

Status: RESOLVED FIXED

(Developer Services :: Mercurial: bzexport, defect)

Description

[Steve Fink [:sfink] [:s:]]

|hg bzexport 12345| should update the top mq patch by default. Right now, it'll only update by default if a new bug is being created. I think I just messed that up.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Update when reusing existing bug

I think it would all probably work if I just did

- update_patch = opts['update'] or opts['new']
+ update_patch = opts['new'] or opts['update']

but this all seems much too cryptic, so spelling it out in detail.

Comment 2

[(not currently active) Ted Mielczarek]

No, I changed this behavior in:
http://hg.mozilla.org/users/tmielczarek_mozilla.com/bzexport/rev/540b04fc2c19

It used to be "only update when you specify --update". I'm fine with it either way, I just figured "put the bug number in the commit message when filing a new bug" was a very inoffensive action. I think "put the bug number in the commit message if there's no bug number already there" is probably similarly inoffensive.

Comment 3

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8363298 [details] [diff] [review]
Update when reusing existing bug

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #2)
> It used to be "only update when you specify --update". I'm fine with it
> either way, I just figured "put the bug number in the commit message when
> filing a new bug" was a very inoffensive action. I think "put the bug number
> in the commit message if there's no bug number already there" is probably
> similarly inoffensive.

Aha! You have an opinion, which means you're itching to review. Perfect!

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 8363298 [details] [diff] [review]
Update when reusing existing bug

Review of attachment 8363298 [details] [diff] [review]:
-----------------------------------------------------------------

I think ideally we'd do the right thing by default here and not need the options, but this is fine.

::: __init__.py
@@ +1006,5 @@
> +            update = True
> +        elif opts['new']:
> +            update = ui.configbool("bzexport", "update-patch", True)
> +        else:
> +            update = ui.configbool("bzexport", "update-patch", False)

This is definitely cleaner.

Comment 5

[Steve Fink [:sfink] [:s:]]

http://hg.mozilla.org/users/tmielczarek_mozilla.com/bzexport/rev/3420668a4f37