Closed
Bug 962393
Opened 11 years ago
Closed 11 years ago
MessageManager should not use JS_InternString
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla29
| Tracking | Status | |
|---|---|---|
| firefox27 | --- | unaffected |
| firefox28 | --- | fixed |
| firefox29 | --- | fixed |
| b2g-v1.3 | --- | fixed |
People
(Reporter: smaug, Assigned: smaug)
References
Details
(Whiteboard: [qa-])
Attachments
(2 files)
|
1.14 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
|
1.16 KB,
patch
|
bajaj
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
We might want this on 1.3.
|
Assignee | |
Comment 2•11 years ago
|
||
at least this compiles
Attachment #8363414 -
Flags: review?(bzbarsky)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8363414 [details] [diff] [review]
JS_NewStringCopyZ
NewStringCopyN would save an strlen here.
r=me with that
Attachment #8363414 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
|
|
Assignee | |
Comment 6•11 years ago
|
||
Comment on attachment 8363420 [details] [diff] [review]
JS_NewStringCopyN
[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 916091
User impact if declined: leak
Testing completed (on m-c, etc.): landed to m-i
Risk to taking this patch (and alternatives if risky): shouldn't be risky
String or IDL/UUID changes made by this patch: NA
Attachment #8363420 -
Flags: approval-mozilla-aurora?
|
|
||
Comment 7•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
|
||
Updated•11 years ago
|
|
|
||
Updated•11 years ago
|
Attachment #8363420 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
||
Comment 8•11 years ago
|
||
status-b2g-v1.3:
--- → fixed
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•