Closed Bug 962393 Opened 6 years ago Closed 6 years ago
Manager should not use JS _Intern String
We might want this on 1.3.
at least this compiles
Attachment #8363414 - Flags: review?(bzbarsky)
Comment on attachment 8363414 [details] [diff] [review] JS_NewStringCopyZ NewStringCopyN would save an strlen here. r=me with that
Attachment #8363414 - Flags: review?(bzbarsky) → review+
Assignee: nobody → bugs
Comment on attachment 8363420 [details] [diff] [review] JS_NewStringCopyN [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 916091 User impact if declined: leak Testing completed (on m-c, etc.): landed to m-i Risk to taking this patch (and alternatives if risky): shouldn't be risky String or IDL/UUID changes made by this patch: NA
Attachment #8363420 - Flags: approval-mozilla-aurora?
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Attachment #8363420 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.