Closed Bug 962452 Opened 7 years ago Closed 7 years ago

[DSDS] Enable or disable automatic selection on SIM 1 will also do the same on SIM 2, vice versa.

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

x86_64
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:1.3+, firefox29 fixed, b2g-v1.3 verified)

VERIFIED FIXED
blocking-b2g 1.3+
Tracking Status
firefox29 --- fixed
b2g-v1.3 --- verified

People

(Reporter: echu, Assigned: arthurcc)

Details

(Whiteboard: dsdsrun1.3-2)

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #960388 +++

Enable or disable automatic selection on SIM 1 will also do the same on SIM 2, vice versa.

* Build Number  
Fugu              
Gaia      a119a0692c24c5ed7c55bab838bae3ecdb9dbec9
Gecko     15ee4e78431b45922b41dea882464b0ccb6b4fac
BuildID   20140110174141
Version   28.0a2

* Steps
1. Go to Settings > Cellular & Data > select SIM 1 > Network operator
2. If it's disable, then keep it, otherwise disable it.
3. Back to SIM picker, select SIM 2.
4. It should be disable, then enable it.
5. Back to SIM picker, select SIM 1.

* Expected Result
SIM 1 is disable 

* Actual Result
SIM 1 automatic selection is enable due to step 4.

* Occurrence rate
100%
100%
Assignee: nobody → arthur.chen
blocking-b2g: 1.3? → 1.3+
The fix changes the RIL internal interface change that affects our partner's RIL, too.
See their concern here: https://bugzilla.mozilla.org/show_bug.cgi?id=961921#c6

And I've discussed with QA:
1.3 user story doesn't explicitly describe if we should have a global setting for this case or not. It makes sense to have separate settings for automatic selection, and that's why QA nominated this as 1.3+.

It's fine to fix it later if there's a concern on partner's side. 
I'd de-nominate and let PM make the call again.
blocking-b2g: 1.3+ → 1.3?
(In reply to Hsin-Yi Tsai  [:hsinyi] from comment #1)
> The fix changes the RIL internal interface change that affects our partner's
> RIL, too.
> See their concern here:
> https://bugzilla.mozilla.org/show_bug.cgi?id=961921#c6
> 
> And I've discussed with QA:
> 1.3 user story doesn't explicitly describe if we should have a global
> setting for this case or not. It makes sense to have separate settings for
> automatic selection, and that's why QA nominated this as 1.3+.
> 
> It's fine to fix it later if there's a concern on partner's side. 
> I'd de-nominate and let PM make the call again.

Oh... sorry, my mistake :(
This is a gaia-only bug and don't touch any ril internal interface. 
Please help mark it back to 1.3+, thanks!!!
blocking-b2g: 1.3? → 1.3+
Jose, could you help review the change? Thanks!
Attachment #8365970 - Flags: review?(josea.olivera)
Comment on attachment 8365970 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/15728

There is still an issue. If we disable automatic selection for ICC card 1 and then go to network operator settings for ICC card 2 we see automatic selection checkbox enabled which is correct but if we keep the panel open for a while the list of operator available gets updated eventually.
Attachment #8365970 - Flags: review?(josea.olivera)
Comment on attachment 8365970 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/15728

Jose, could you review it again? I've refactored the gOperatorNetworkList a little bit so that we can avoid the old requests affecting the current UI.
Attachment #8365970 - Flags: review?(josea.olivera)
Comment on attachment 8365970 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/15728

LGTM, tested on fugu and peak devices. The flow of calls to the functions for searching networks, enable/disable automatic selection seems correct for each ICC card. The issue commented on comment #4 gets fixed now. However after setting the network selection option 'manual' by clicking on a carrier in the list the device never connects and it keeps connecting eternally. This cause if the user selects network selection option 'automatic' the call to `selectNetworkAutomatically()` function fails (see error below please). We should file a follow-up bug and figure out whether there is something fishy here or not (at least the onerror() function should be called). This work belongs to the RIL plumbing and there is nothing to do (If I'm right) in Gaia side. Thanks Arthur, please squash the commits in the PR and land at will.

E/GeckoConsole(  398): [JavaScript Error: "[Exception... "Error: Already selecting a network: [xpconnect wrapped nsIDOMMozMobileNetworkInfo]'Error: Already selecting a network: [xpconnect wrapped nsIDOMMozMobileNetworkInfo]' when calling method: [nsIMobileConnectionProvider::selectNetworkAutomatically]"  nsresult: "0x8057001c (NS_ERROR_XPC_JS_THREW_JS_OBJECT)"  location: "JS frame :: app://settings.gaiamobile.org/js/carrier.js :: cs_initOperatorSelector/opAutoSelectInput.onchange :: line 378"  data: no]" {file: "app://settings.gaiamobile.org/js/carrier.js" line: 378}]
E/GeckoConsole(  398): [JavaScript Error: "NS_ERROR_XPC_JS_THREW_JS_OBJECT: Error: Already selecting a network: [xpconnect wrapped nsIDOMMozMobileNetworkInfo]'Error: Already selecting a network: [xpconnect wrapped nsIDOMMozMobileNetworkInfo]' when calling method: [nsIMobileConnectionProvider::selectNetworkAutomatically]" {file: "app://settings.gaiamobile.org/js/carrier.js" line: 378}]
Attachment #8365970 - Flags: review?(josea.olivera) → review+
Thanks for the detailed testing, Jose. I'll check this issue and file a follow up bug.

master: b4860ec2f3829c57f68792a0cc6875065bf6c3b0
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Bug 965143 was create for following up.
Uplifted b4860ec2f3829c57f68792a0cc6875065bf6c3b0 to:
v1.3: 725fef1c706090c474cc684d790f3851742ff2fa
Verified.

Fugu - 
Gaia      bb36b4164d3e51ca04b612e507e1178f80bf240d
Gecko     4227240a4d3e1e418ced160c2a48cb454d7b5645
BuildID   20140204104742
Version   28.0
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.