962505 - fix display list printing to play nicely with fennec and b2g

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Timothy Nikkel (:tnikkel)]

Attachment: patch

The output for a single fprintf_stderr call ends up on its own line in the logcat output even if there is no newline in the string. So we have to create the the whole and then output it at once. Printing out indentation spaces makes the output somewhat hard to interpret.

Comment 1

[Mats Palmgren (inactive)]

Comment on attachment 8363566 [details] [diff] [review]
patch

While you're here, please add MOZ_OVERRIDE on the first WriteDebugInfo
in layout/base/nsDisplayList.h too.

Same comment as before regarding nsAutoCString.

Comment 2

[Timothy Nikkel (:tnikkel)]

Attachment: output the scroll and scrolled frames for scroll layer items

Putting this in here because it's small and not worth another bug.

Comment 3

[Timothy Nikkel (:tnikkel)]

(In reply to Mats Palmgren (:mats) from comment #1)
> Comment on attachment 8363566 [details] [diff] [review]
> patch
> 
> While you're here, please add MOZ_OVERRIDE on the first WriteDebugInfo
> in layout/base/nsDisplayList.h too.

I'm not sure what you mean here, all the WriteDebugInfo have MOZ_OVERRIDE that I can tell, except for the original declaration, which isn't an override.

> Same comment as before regarding nsAutoCString.

Done.

Comment 4

[Mats Palmgren (inactive)]

Sorry, I didn't realize the first one was actually the root.

Comment 5

[Timothy Nikkel (:tnikkel)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b7f02d545988
https://hg.mozilla.org/integration/mozilla-inbound/rev/bd61bfb42d02

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b7f02d545988
https://hg.mozilla.org/mozilla-central/rev/bd61bfb42d02