Closed Bug 962624 Opened 6 years ago Closed 4 years ago

Add an approximate parent node name for layers dump

Categories

(Core :: Layout, enhancement)

x86
macOS
enhancement
Not set

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: BenWa, Assigned: BenWa)

References

Details

Attachments

(1 file, 2 obsolete files)

Currently layers are hard to debug. It's even harder when just trying to match a layers dump and a screenshot from a bug report. I'd like to propose that we throw it an approximate node name for the layer' closes parent element if that possible.

I think I saw botond have something similar in his local patch queue? I'd like to get this landed in layers dump.
Flags: needinfo?(botond)
Good timing :) I'll be posting a patch to bug 958596 today that you'll be able to make use of for this purpose.
Flags: needinfo?(botond)
See Also: → 958596
(In reply to Botond Ballo [:botond] from comment #1)
> Good timing :) I'll be posting a patch to bug 958596 today that you'll be
> able to make use of for this purpose.

More specifically, my patches to this for scrollable layers. If you want to do it for all layers, there is likely to be some additional work involved.
Severity: normal → enhancement
Assignee: nobody → bgirard
Depends on: 958596
Attached patch WIP (obsolete) — Splinter Review
Doesn't build right now because I'm in the middle of remoting LayerDebugInfo.
Attached patch WIP + rebase + IPC Traits (obsolete) — Splinter Review
Attachment #8367803 - Attachment is obsolete: true
Working. The content name are too verbose:

    ContainerLayerComposite (0x11a766400) [shadow-clip=(x=0, y=158, w=2072, h=2060)] [shadow-visible=< (x=0, y=158, w=2072, h=2060); >] [clip=(x=0, y=158, w=2072, h=2060)] [visible=< (x=0, y=158, w=2072, h=2060); >] [opaqueContent]
      Debug Info: content='xul:browser@11a230e90 anonid="initialBrowser" type="content-primary" message="true" xbl:inherits="tooltip=contenttooltip,contextmenu=contentcontextmenu,autocompletepopup,selectpopup" selectpopup="ContentSelectDropdown" contextmenu="contentAreaContextMenu" tooltip="aHTMLTooltip" autocompletepopup="PopupAutoComplete" clickthrough="never" autoscrollpopup="autoscroller"', reasons='Force,'
      ThebesLayerComposite (0x11a767000) [shadow-transform=[ 1 0; 0 1; 0 158; ]] [shadow-visible=< (x=0, y=0, w=2072, h=2060); >] [transform=[ 1 0; 0 1; 0 158; ]] [visible=< (x=0, y=0, w=2072, h=2060); >] [opaqueContent] [valid=< (x=0, y=0, w=2072, h=2060); >]
Attachment #8403643 - Attachment is obsolete: true
I landed something similar in another bug.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.