Closed Bug 962648 Opened 6 years ago Closed 6 years ago

Ship LGPL-licensed Swedish dictionary

Categories

(mozilla.org :: Licensing, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: u60234, Assigned: u60234)

Details

Attachments

(1 file, 2 obsolete files)

The Swedish l10n team would like to ship the spell-checking dictionary from https://addons.mozilla.org/en-US/firefox/addon/görans-hemmasnickrade-ordli/ in Swedish builds of Firefox.

The dictionary is licensed under LGPL 3.0.

Can you tell us if that is OK?
Yes, we now ship LGPL code, which can include dictionaries. You need to add a note to about:license (ideally build-conditional; not sure how easy that is) in the LGPL section.

https://wiki.mozilla.org/L10n:Dictionaries

Gerv
I don't think it is possible to ship this note just for Swedish versions, since they are not built separately. So I added the same caveat that has been used for other dictionary licenses.
Attachment #8364482 - Flags: review?(gerv)
Comment on attachment 8364482 [details] [diff] [review]
Add license block for Swedish dictionary

No, not like this. I was going to say to add it to the list of directory names at the top of the existing LGPL text in the file. However, I didn't realise it was LGPLv3+. That means we need a whole new license text, because our current LGPL text is LGPLv2.

It would be really awesome if you could devise a way to get the preprocessor to conditionally include this text... I'd rather not add however many extra lines to about:license just for the Swedish version...

Gerv
Attachment #8364482 - Flags: review?(gerv) → review-
Attached patch With LGPL3 text (obsolete) — Splinter Review
The preprocessor is unfortunately not going to help us here. The l10n builds are not generated by a full rebuild of the app, but by repacking the main (en-US) build with the locale files for the various locales. As license.html is not a localizable file, all language versions will share the same version of license.html that was created in the main build.

If file size is a concern, could we not replace the current LGPLv2.1 text with the LGPLv3 text? It seems to be used only by the Estonian dictionary (no version specified), and the libsoundtouch library (version 2.1, or later).
Attachment #8364482 - Attachment is obsolete: true
Attachment #8365495 - Flags: review?(gerv)
Comment on attachment 8365495 [details] [diff] [review]
With LGPL3 text

Thinking about it, I think we should just add the LGPLv3 with a note at the top. So r+ on that bit, and r- on the about:license#hunspell-sv part - you don't need to add that text to about:license at all. That text is designed to show that a file is under a particular license; it's not the license itself.

Please can you check that none of the IDs on the HTML elements you've added with the LGPLv3 text clash with IDs elsewhere in the document?

Gerv
Attachment #8365495 - Flags: review?(gerv) → review+
Attached patch LGPL3 text onlySplinter Review
Patch without the Swedish dictionary note.

I double-checked the file and found no ID clashes for the new elements.
Assignee: gerv → hasse
Attachment #8365495 - Attachment is obsolete: true
Attachment #8366738 - Flags: review?(gerv)
Comment on attachment 8366738 [details] [diff] [review]
LGPL3 text only

r=gerv.

Gerv
Attachment #8366738 - Flags: review?(gerv) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/6d1ac6ea7854
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
You need to log in before you can comment on or make changes to this bug.