Closed Bug 962676 Opened 7 years ago Closed 7 years ago

Assertion count mismatches during various crashtests on Android 4.0 Debug

Categories

(Firefox for Android :: General, defect)

x86
Android
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 33

People

(Reporter: gbrown, Assigned: gbrown)

References

Details

Attachments

(1 file)

Android 4.0 *Debug* tests currently only run on the Cedar tree. We are trying to get these tests to pass so that they can be run on trunk trees.

On Cedar, on Android 4.0 Debug, crashtests tests consistently fail with various assertion count mismatches:

https://tbpl.mozilla.org/php/getParsedLog.php?id=33337466&tree=Cedar&full=1

REFTEST TEST-UNEXPECTED-PASS | data:text/html, | assertion count 0 is less than expected 8 to 10 assertions
REFTEST TEST-UNEXPECTED-PASS | http://10.12.133.21:30582/tests/docshell/base/crashtests/436900-1.html | assertion count 0 is less than expected 2 assertions
REFTEST TEST-UNEXPECTED-PASS | http://10.12.133.21:30582/tests/dom/base/crashtests/90613-1.html | assertion count 0 is less than expected 1 assertions
REFTEST TEST-UNEXPECTED-PASS | http://10.12.133.21:30582/tests/dom/xbl/crashtests/493123-1.xhtml | assertion count 0 is less than expected 2 assertions
REFTEST TEST-UNEXPECTED-PASS | http://10.12.133.21:30582/tests/editor/composer/src/crashtests/351236-1.html | assertion count 0 is less than expected 2 assertions
REFTEST TEST-UNEXPECTED-PASS | http://10.12.133.21:30582/tests/layout/base/crashtests/265986-1.html | assertion count 3 is less than expected 6 to 12 assertions
REFTEST TEST-UNEXPECTED-PASS | http://10.12.133.21:30582/tests/layout/base/crashtests/266360-1.html | assertion count 1 is less than expected 2 to 7 assertions
REFTEST TEST-UNEXPECTED-PASS | http://10.12.133.21:30582/tests/layout/base/crashtests/477731-1.html | assertion count 0 is less than expected 6 assertions
REFTEST TEST-UNEXPECTED-PASS | http://10.12.133.21:30582/tests/layout/base/crashtests/480686-1.html | assertion count 0 is less than expected 6 assertions
REFTEST TEST-UNEXPECTED-PASS | http://10.12.133.21:30582/tests/layout/base/crashtests/898913.html | assertion count 2 is less than expected 4 to 6 assertions
REFTEST TEST-UNEXPECTED-PASS | http://10.12.133.21:30582/tests/layout/forms/crashtests/378413-1.xhtml | assertion count 4 is less than expected 5 to 10 assertions
REFTEST TEST-UNEXPECTED-PASS | http://10.12.133.21:30582/tests/layout/forms/crashtests/383887-1.html | assertion count 0 is less than expected 1 assertions
REFTEST TEST-UNEXPECTED-PASS | http://10.12.133.21:30582/tests/layout/generic/crashtests/394818-2.html | assertion count 0 is less than expected 1 assertions
REFTEST TEST-UNEXPECTED-PASS | http://10.12.133.21:30582/tests/layout/generic/crashtests/414061-1.html | assertion count 0 is less than expected 6 assertions
REFTEST TEST-UNEXPECTED-FAIL | http://10.12.133.21:30582/tests/layout/generic/crashtests/499885-1.xhtml | assertion count 4 is more than expected 0 assertions
REFTEST TEST-UNEXPECTED-PASS | http://10.12.133.21:30582/tests/layout/generic/crashtests/673770.html | assertion count 0 is less than expected 8 assertions
REFTEST TEST-UNEXPECTED-PASS | http://10.12.133.21:30582/tests/layout/generic/crashtests/798020-1.html | assertion count 0 is less than expected 8 assertions
REFTEST TEST-UNEXPECTED-PASS | http://10.12.133.21:30582/tests/layout/generic/crashtests/847209.html | assertion count 2 is less than expected 4 assertions
REFTEST TEST-UNEXPECTED-PASS | http://10.12.133.21:30582/tests/layout/xul/tree/crashtests/366583-1.xul | assertion count 0 is less than expected 3 assertions
REFTEST TEST-UNEXPECTED-PASS | http://10.12.133.21:30582/tests/parser/htmlparser/tests/crashtests/328751-1.html | assertion count 0 is less than expected 1 assertions

(There is also a crash in this log -- see bug 940087.)

Unfortunately, not enough logcat is reported to see the failed assertions.

One approach to resolving this would be to reproduce the failures on a local device with a debug build while observing logcat.

There are on-going efforts to report complete logcats on tbpl, but I am not sure how long it will be before a working solution is available.

See https://tbpl.mozilla.org/?tree=Cedar&showall=1&jobname=android.*debug for more logs.
:blassey -- Please find an owner. Note that most of these are unexpected passes -- this might be as easy as updating the tests to expect 0 assertions.
Flags: needinfo?(blassey.bugs)
Depends on: 982892
Depends on: 982895
Depends on: 982897
Depends on: 982901
Depends on: 982905
Depends on: 982908
Depends on: 982911
Depends on: 982913
Depends on: 982915
Depends on: 982917
Depends on: 982919
Depends on: 982920
Depends on: 982954
Depends on: 982955
Depends on: 982958
Depends on: 982961
Depends on: 982962
Depends on: 982963
Each failure is now reported in its own dependent bug -- they all need owners.
ms2ger, it looks like you added all (or at least most) of these assertions in bug 684807. Were we running debug tests back then?? If not, how were you hitting these assertions in the first place?
Flags: needinfo?(blassey.bugs)
(In reply to Brad Lassey [:blassey] (use needinfo?) from comment #5)
> ms2ger, it looks like you added all (or at least most) of these assertions
> in bug 684807. Were we running debug tests back then?? If not, how were you
> hitting these assertions in the first place?

s/assertions/annotations/
I think we ran them, but we shut them off because they didn't have stacks, and then presumably a bunch were fixed since.
This patch deals with the lowest hanging fruit here: Removes the asserts-if(Android) manifest notations that are causing failures. 

This reduces the set of failures to:

REFTEST TEST-UNEXPECTED-PASS | http://10.12.133.23:30599/tests/layout/base/crashtests/266360-1.html | assertion count 1 is less than expected 2 to 7 assertions
REFTEST TEST-UNEXPECTED-PASS | http://10.12.133.23:30599/tests/layout/base/crashtests/898913.html | assertion count 2 is less than expected 4 to 6 assertions
REFTEST TEST-UNEXPECTED-PASS | http://10.12.133.23:30599/tests/layout/forms/crashtests/378413-1.xhtml | assertion count 4 is less than expected 5 to 10 assertions
REFTEST TEST-UNEXPECTED-PASS | http://10.12.133.23:30599/tests/layout/generic/crashtests/798020-1.html | assertion count 0 is less than expected 8 assertions
REFTEST TEST-UNEXPECTED-PASS | http://10.12.133.23:30599/tests/layout/generic/crashtests/847209.html | assertion count 2 is less than expected 4 assertions

These remaining cases are caused by asserts() or more generic asserts-if() (not specific to Android).
Attachment #8403277 - Flags: review?(blassey.bugs)
Attachment #8403277 - Flags: review?(blassey.bugs) → review+
Depends on: 1021998
Assignee: nobody → gbrown
All dependent bugs fixed.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [leave open]
Target Milestone: --- → Firefox 33
You need to log in before you can comment on or make changes to this bug.