962712 - Update message text for "%Invitee% created a Mozillians profile" email

Status: VERIFIED FIXED

(Participation Infrastructure :: Phonebook, defect)

Description

[William Reynolds [:williamr]]

When a vouched user invites someone to Mozillians and the invitee creates a profile, we notify the voucher. The message is missing the invitee's name in both the subject and body. We could also provide more context in this message and provide line returns in the body.

Suggested subject: $invitee_name$ created a Mozillians profile

Suggested body:

"Hi $voucher_name$,

You invited $invitee_name% to create a profile on mozillians.org. Take a look at their shiny, new profile: %invitee_profile_url%

Thanks for inviting a contributor to join our community directory!

The Mozillians.org Team"

Comment 1

[Kevin Lam]

Hi! Could I work on this? I'm completely new to this, so it'll be my first bug. Thanks!

Comment 2

[Giorgos Logiotatidis [:giorgos]]

Hi Kevin!

Thanks for offering to contribute. This is a django / python bug, are you new to mozilla or/and in python/django?

Comment 3

[Kevin Lam]

I have some experience with Django / Python, but am new to Mozilla. Will that be okay?

Comment 4

[Giorgos Logiotatidis [:giorgos]]

Kevin,

Yes that's perfectly OK. Please OK ahead and setup your environment following the instructions here:

http://mozillians.readthedocs.org/

and let me know, by commenting here, when you're ready.


I'm assigning this bug to you. Good luck!

Comment 5

[Kevin Lam]

Giorgos,

Just wanted to let you know - I finished setting up my environment. What are the next steps?

Comment 6

[Giorgos Logiotatidis [:giorgos]]

Hi Kevin,

Now you need to fix this bug! This bug is about updating the email template used in method 

mozillians.phonebook.models.Invite.send_thanks

with the text supplied in comment #1. 

Please read the contribution guidelines for our project http://mozillians.readthedocs.org/en/latest/contribute.html 

Feel free to ping me on IRC or here with questions and/or comments.

Comment 7

[Kevin Lam]

Giorgos,

I changed to the template named "invited_accepted.txt" so that it now uses the suggested message. 

The subject line seems to be exactly the same, so I left it alone. The template seems to already have the invitee's name in both the subject and the body, unless I'm mistaken in thinking that "friend" refers to the invitee. This is all based off of what I saw in the send_thanks method and the associated template. Sorry if it sounds kind of dumb!

Also, I tried to run "./manage.py test" but I kept getting import errors. I feel like I may have messed up during the installation process somehow. Do you think you can help me out?

Thanks so much!

Comment 8

[William Reynolds [:williamr]]

(In reply to Kevin Lam from comment #7)
> The subject line seems to be exactly the same, so I left it alone. The
> template seems to already have the invitee's name in both the subject and
> the body, unless I'm mistaken in thinking that "friend" refers to the
> invitee. This is all based off of what I saw in the send_thanks method and
> the associated template. Sorry if it sounds kind of dumb!

The text for the subject line is not changing. However, this bug is meant to fix an issue with the names not being displayed in both the subject and body. For some reason the names are not being output properly in both of those locations. We want to output all the names properly, in addition to the text changes in the body message.

Thanks again for your help with this, Kevin!

Comment 9

[Kevin Lam]

I think I may have found the issue. In the edit_profile method of phonebook/views.py, the name is not being passed to the request.user.userprofile after compeleting a profile. I just assigned the full_name value to the request.user.userprofile.full_name field and it seems to fix the issue. Spcifically, right below line 178 I just added:

request.user.userprofile.full_name = profile.full_name

Comment 10

[William Reynolds [:williamr]]

That is great Kevin! Good job tracking down the issue.

Once you have the code ready for review, please submit a pull request with the appropriate commit message and then add a comment here with a link to the pull request. Be sure to squash your commits into one commit as noted in step 7 of the workflow.

You can see see the commit message format and the git workflow here

https://github.com/mozilla/mozillians/commits/master

http://mozillians.readthedocs.org/en/latest/contribute.html#git-workflow

Comment 11

[Kevin Lam]

Here's the pull request: https://github.com/mozilla/mozillians/pull/864

Took me a while to find the root cause! I hope it helps. Please let me know if I need to do anything else for this issue.

Comment 12

[Kevin Lam]

Hey Giorgos,

I've re-submitted my pull request with your suggested changes. Could you take a look at it and let me know what you think? The link is:

https://github.com/mozilla/mozillians/pull/876

Comment 13

[Kevin Lam]

Sorry, I had a trailing whitespace. Just re-submitted:

https://github.com/mozilla/mozillians/pull/877

Comment 14

[[github robot]]

Commit pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/268f87af9a0d4c3c39b5d2a91f31f615b2d4fe02
[fix bug 962712] Fix missing invitee name.

Comment 15

[Matt Brandt [:mbrandt]]

Attachment: qa - verified on stage

Well done! QA verified on stage - once an invitation has been accepted and and successfully created an account on Mozillians an email is sent to the Mozillian who initiated the invite - matches the spec in commemnt 0.

- paths tested
0. invitee doesn't yet have a Persona account
1. invitee has an existing Persona account

Comment 16

[Kevin Lam]

Awesome! Time to grab another bug :)

Comment 17

[Matt Brandt [:mbrandt]]

Yahoo! Thanks Kevin!