Closed Bug 96272 Opened 23 years ago Closed 23 years ago

another memory leak in pcertdb.c

Categories

(NSS :: Libraries, defect, P2)

x86
Windows 2000
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jeff, Assigned: rrelyea)

References

Details

(Keywords: memory-leak, perf)

see also bug 93412, bug 93450, and bug 93485.

we also need to free handle->dbMon in CERT_Shutdown().


#if 1//begin JLH added (93412)
void CERT_Shutdown(CERTCertDBHandle * handle)
{
    if ( handle->tempCertDB ) {
	certdb_Close(handle->tempCertDB);
	handle->tempCertDB = 0;
    }

#if 1//begin JLH added (93450)
    if (dbLock)
    {
	PZ_DestroyLock(dbLock);
	dbLock = NULL;
    }
#endif//end JLH added (93450)

#if 1//begin JLH added (93485)
    if (handle->spkDigestInfo)
    {
	SPKDigestInfo *spkDigestInfo = handle->spkDigestInfo;
	if (spkDigestInfo->table)
	{
	    PL_HashTableDestroy(spkDigestInfo->table);
	}
	PORT_Free(spkDigestInfo);
	handle->spkDigestInfo = NULL;
    }
#endif//end JLH added (93485)

#if 1//begin JLH added (<this_bug>)
    if (handle->dbMon)
    {
	PZ_DestroyMonitor(handle->dbMon);
	handle->dbMon = NULL;
    }
#endif//end JLH added (<this_bug>)
}
#endif//end JLH added (93412)
Whoohoo...Marking NEW. thanks again.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: mlk, patch, perf, review
Blocks: 92580
No longer blocks: 92580
Assigned the bug to Bob.
Assignee: wtc → relyea
Priority: -- → P2
Target Milestone: --- → 3.4
fixed in NSS 3.4
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.