962736 - Update Shumway to version 0.8.6

Status: RESOLVED FIXED

(Firefox Graveyard :: Shumway, defect)

Description

[Yury Delendik (:yury)]

Log:

#1062 Monomorphize some more function calls
#945 Adds a "Report Problems" entry to the extension's context menu
#975 Fixes #1066
#1068 Refactor streaming source to use MediaSource
#1070 Cleanup
#1071 Refactors initialization from the FirefoxCom
#1072 Introduces FrameScheduler
#1073 Improves frame scheduler; adds mp3 playback off-sync tracking
#1076 Ignore mouse events on HUD display

Comment 1

[Yury Delendik (:yury)]

Attachment: Update Shumway to version 0.8.2

Comment 2

[Till Schneidereit [:till]]

Comment on attachment 8363888 [details] [diff] [review]
Update Shumway to version 0.8.2

Review of attachment 8363888 [details] [diff] [review]:
-----------------------------------------------------------------

patch looks good. r=me on the structure and all, with the understanding that the actual code changes aren't reviewed.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

patching file browser/metro/base/tests/mochitest/browser_selection_basic.js
bad hunk #1 @@ -313,15 +313,47 @@ gTests.push({
 (15 15 48 47)

Comment 4

[Ryan VanderMeulen [:RyanVM]]

(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #3)
> patching file browser/metro/base/tests/mochitest/browser_selection_basic.js
> bad hunk #1 @@ -313,15 +313,47 @@ gTests.push({
>  (15 15 48 47)

Wrong bug, sorry.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/24fda7c805e3

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out in https://hg.mozilla.org/integration/fx-team/rev/7a7ba4d11e5e because either this or bug 962736 (or much less likely one of the other patches Ryan pushed with them) permanently broke xperf tests on Win7:
https://tbpl.mozilla.org/php/getParsedLog.php?id=33488315&tree=Fx-Team

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

The backout went green, so it was one of these two patches that broke it.

Comment 8

[Till Schneidereit [:till]]

Am I correct in assuming that the text in comment 6 was copy-pasted from the other suspected bug, and that this bug is, indeed, the much less likely candidate? The error doesn't look like something this patch could conceivably have caused.

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(In reply to Till Schneidereit [:till] from comment #8)
> Am I correct in assuming that the text in comment 6 was copy-pasted from the
> other suspected bug, and that this bug is, indeed, the much less likely
> candidate? The error doesn't look like something this patch could
> conceivably have caused.

Ugh, yeah, sorry, it was copy/pasted from bug 960051. The two much-less likely patches I was talking about were Android-only or a three-line change to a CSS file, neither of which seemed like it would make Windows tests access those three files.

Since my backout turned it green, either Shumway's update in this bug or pdf.js's update in 960051 caused it.

Comment 10

[Till Schneidereit [:till]]

In that case, my money is on bug 960051: it has password prompting-related changes, so changed patterns of key storage accesses seem to make sense.

The update here, OTOH, is really unlikely to be related.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Sounds plausible to me.
https://hg.mozilla.org/integration/fx-team/rev/41143dba70eb

Comment 12

[Ryan VanderMeulen [:RyanVM]]

This did cause the xperf regression. Backed out.
https://hg.mozilla.org/integration/fx-team/rev/861d0354e018

Comment 13

[Yury Delendik (:yury)]

Attachment: Update Shumway to version 0.8.6

Additional changes:

#1088 Factor out all text layout from TextField into TextFieldContent
#1089 Lazy initialization of AddonManager; async getVersionInfo()


Try push
https://hg.mozilla.org/try/rev/fd900d9b5ceb

Comment 14

[Yury Delendik (:yury)]

Sorry, try push at https://tbpl.mozilla.org/?tree=Try&rev=43f20c256dcd

Comment 15

[Till Schneidereit [:till]]

Comment on attachment 8365078 [details] [diff] [review]
Update Shumway to version 0.8.6

Review of attachment 8365078 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the try run returning green. And sorry for the mess.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/4f4f4b20efc7

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4f4f4b20efc7