Closed Bug 962739 Opened 10 years ago Closed 10 years ago

Loader should work with getters

Categories

(Add-on SDK Graveyard :: General, defect)

Product:
Add-on SDK Graveyard
Component:
General
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: jsantell, Unassigned)

Details

Currently, getters on module exports are only called once and then baked:

`Object.defineProperties(exports, 'prop', { get: fn }`
`fn` is only called once and returns a value, and then always will return the initial value.
This was due to destructuring, and removing the property away from its parent object:
`let { prop } = require('./mod')`

This makes sense in terms of how getters work in ES5, but having getters on exports seems like something we should avoid for this reason.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.