962761 - [email] better l10n string for default attachment name

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[James Burke [:jrburke]]

Bug 960282 introduced a new l10n string for default attachment name. However, it used a plural form for the l10n string, which is not applicable for this particular case. See bug 960282, comment 9 for the start of that conversation.

End result, replace the `default-attachment-name` use with a new string name that just has the singular form for the name, with the number of the attachment passed in, something like:

default-attachment-name=attachment{{ n }}

As noted in the conversation on the other bug, this does not need to change for 1.3, this is just to apply to master for best practices going forward.

Comment 1

[James Burke [:jrburke]]

Attachment: GitHub pull request

Creates a new string key, `default-attachment-filename`, to store the l10n string and removes the old string as it is no longer used.

Asking :flod for review as he caught the original issue.

Comment 2

[Francesco Lodolo [:flod]]

Comment on attachment 8363928 [details] [review]
GitHub pull request

Change looks good to me, but it's better if a real Gaia reviewer approves it ;-)

Comment 3

[James Burke [:jrburke]]

Comment on attachment 8363928 [details] [review]
GitHub pull request

Oops, yes, I should have asked for r? from :asuth, as he reviewed original related changeset, and just feedback? from :flod.

Comment 4

[James Burke [:jrburke]]

Merged gaia master:
https://github.com/mozilla-b2g/gaia/pull/15614

from pull request:
https://github.com/mozilla-b2g/gaia/pull/15614