Closed Bug 962764 Opened 6 years ago Closed 6 years ago

Support 4.4 sdk

Categories

(Firefox for Android :: General, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 29

People

(Reporter: wesj, Assigned: wesj)

Details

Attachments

(1 file)

With 4.4 SDK downloaded, I'm getting complaints that dx can't be found.
Attached patch PatchSplinter Review
This feels fragile, but I don't know autoconf well :)
Attachment #8363920 - Flags: review?(gps)
Attachment #8363920 - Flags: review?(blassey.bugs)
Argh. Forgot to qref out the un-necessary stuff that snuck in here. Leaving it for now to avoid email churn.
Attachment #8363920 - Flags: review?(gps) → review+
Comment on attachment 8363920 [details] [diff] [review]
Patch

Review of attachment 8363920 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/autoconf/android.m4
@@ +293,5 @@
>      fi
>      # The build tools got moved around to different directories in
>      # SDK Tools r22.  Try to locate them.
>      android_build_tools=""
> +    for suffix in android-4.4 android-4.3 19.0.0 18.1.0 18.0.1 18.0.0 17.0.0 android-4.2.2; do

might as well put these in some sort of order, how about:
"android-4.4 android-4.3 android-4.2.2 19.0.0 18.1.0 18.0.1 18.0.0 17.0.0"
Attachment #8363920 - Flags: review?(blassey.bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/6a0d10124e8d
Assignee: nobody → wjohnston
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
You need to log in before you can comment on or make changes to this bug.