962784 - Convert ImageTypes.h to typed enums

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: Convert ImageTypes.h to typed enums

Just one big patch, mostly automatic changes generated by the commands in the commit message. The manual changes are mostly in ImageClient.* and ImageContainer.*.

Comment 1

[Benoit Jacob [:bjacob] (mostly away)]

https://tbpl.mozilla.org/?tree=Try&rev=4687e538fdd2

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8363941 [details] [diff] [review]
Convert ImageTypes.h to typed enums

Review of attachment 8363941 [details] [diff] [review]:
-----------------------------------------------------------------

This will not build

Comment 3

[Benoit Jacob [:bjacob] (mostly away)]

https://tbpl.mozilla.org/?tree=Try&rev=011b2e971e4d

Comment 4

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: Convert ImageTypes.h to typed enums

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8364624 [details] [diff] [review]
Convert ImageTypes.h to typed enums

Review of attachment 8364624 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/client/ImageClient.cpp
@@ +509,5 @@
>          img = new GrallocImage();
>          return img.forget();
>  #endif
> +      default:
> +        continue; // keep iterating over aFormats

This function doesn't make sense to me. Please fix bug 964442 before landing this.

Comment 6

[Benoit Jacob [:bjacob] (mostly away)]

https://tbpl.mozilla.org/?tree=Try&rev=3242dc38c8d5

Comment 7

[Benoit Jacob [:bjacob] (mostly away)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/739b4300adae

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/739b4300adae