Closed Bug 962784 Opened 6 years ago Closed 6 years ago

Convert ImageTypes.h to typed enums

Categories

(Core :: Graphics, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: bjacob, Assigned: bjacob)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file, 1 obsolete file)

Just one big patch, mostly automatic changes generated by the commands in the commit message. The manual changes are mostly in ImageClient.* and ImageContainer.*.
Attachment #8363941 - Flags: review?(jmuizelaar)
Comment on attachment 8363941 [details] [diff] [review]
Convert ImageTypes.h to typed enums

Review of attachment 8363941 [details] [diff] [review]:
-----------------------------------------------------------------

This will not build
Attachment #8363941 - Flags: review?(jmuizelaar) → review-
Attachment #8363941 - Attachment is obsolete: true
Attachment #8364624 - Flags: review?(jmuizelaar)
Attachment #8364624 - Flags: review?(jmuizelaar) → review?(bgirard)
Attachment #8364624 - Flags: review?(bgirard) → review?(jmuizelaar)
Comment on attachment 8364624 [details] [diff] [review]
Convert ImageTypes.h to typed enums

Review of attachment 8364624 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/client/ImageClient.cpp
@@ +509,5 @@
>          img = new GrallocImage();
>          return img.forget();
>  #endif
> +      default:
> +        continue; // keep iterating over aFormats

This function doesn't make sense to me. Please fix bug 964442 before landing this.
Attachment #8364624 - Flags: review?(jmuizelaar) → review+
Depends on: 964442
Assignee: nobody → bjacob
https://hg.mozilla.org/mozilla-central/rev/739b4300adae
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.