Closed Bug 962815 Opened 10 years ago Closed 10 years ago

Dismissing pin site popup makes the pin button stay highlighted.

Categories

(Firefox for Metro Graveyard :: App Bar, defect, P2)

Product:
Firefox for Metro Graveyard
Component:
App Bar
Platform:
x86_64
Windows 8.1
Type:
defect

Tracking

(firefox28 verified, firefox29 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 29
Tracking Flags:
Tracking Status
firefox28 --- verified
firefox29 --- verified

People

(Reporter: rsilveira, Assigned: emtwo)

References

Details

(Whiteboard: [release28] [defect] p=1)

Attachments

(1 file)

v1: Update pin button after pin decision is made
2.07 KB, patch
rsilveira
: review+
Details | Diff | Splinter Review 
STR:
1. Navigate to a site and click "pin to start" on nav bar
2. Dismiss the popup by clicking somewhere in content outside the popup

Expected:
Pin button goes back to initial 'unselected' state.

Actual:
Pin button is in 'selected' state giving the impression that the tile was created, even though it wasn't. It only creates when you click 'pin to start' on the popup. Clicking on it unselects.
Blocks: metrov1backlog
Whiteboard: [triage] [defect] p=0
Whiteboard: [triage] [defect] p=0 → [release28] [defect] p=0
Whiteboard: [release28] [defect] p=0 → [release28] [defect] p=1
Assignee: nobody → msamuel
Blocks: metrov1it23
No longer blocks: metrov1backlog
Status: NEW → ASSIGNED
Priority: -- → P2
QA Contact: jbecerra
Comment on attachment 8366671 [details] [diff] [review]
v1: Update pin button after pin decision is made

Review of attachment 8366671 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good and works fine.
Attachment #8366671 - Flags: review?(rsilveira) → review+
https://hg.mozilla.org/integration/fx-team/rev/a24ad25815b9
Whiteboard: [release28] [defect] p=1 → [release28] [defect] [fixed-in-fx-team] p=1
https://hg.mozilla.org/mozilla-central/rev/a24ad25815b9
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [release28] [defect] [fixed-in-fx-team] p=1 → [release28] [defect] p=1
Target Milestone: --- → Firefox 29
Verified as fixed on latest Aurora and latest Nightly with the STR from comment 0 using a Surface Pro 2 device.
Status: RESOLVED → VERIFIED
status-firefox28: fixed → verified
status-firefox29: fixed → verified
You need to log in before you can comment on or make changes to this bug.