962912 - Custom APN fail to apply if default APN does not exist

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[pgravel]

If there is no default APN for a sim card, custom APN settings fail to apply. This issue was seen when using a sim card that was not recognized by the apn database.

This is due to a bad assumption in the buildAndStoreApnSettings function in apps/settings/carrier.js
When applying new APN settings the code tries to merge the new settings with the existing APNs. However, if no APN exist for that card then the for loop never gets executed and the new apnToBeMerged data never gets applied.

Can be solved by adding a check before the for loop:

> if (apnsForIccCard.length == 0) {
>   apnToBeMerged.types = [type];
>   newApnsForIccCard.push(apnToBeMerged);
> } else {
>   for (var apnIndex = 0; apnIndex < apnsForIccCard.length; apnIndex++) {
>      ...
>   }
> }

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Jose, would you be able to fix this bug?

Comment 2

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #1)
> Jose, would you be able to fix this bug?

Yes, it under my radar. I'll take once I finish the other 1.3+ I have. (I expect to fix this issue early next week).

Comment 3

[José Antonio Olivera Ortega [:jaoo]]

I'll try to do my best and fix this bug before 01/31 but as I commented I'll take once I finish the other 1.3+ I have.

Comment 4

[José Antonio Olivera Ortega [:jaoo]]

Attachment: WIP branch at https://github.com/jaoo/gaia/tree/962912

Comment 5

[José Antonio Olivera Ortega [:jaoo]]

Attachment: Pointer to Github PR https://github.com/mozilla-b2g/gaia/pull/15726

Comment 6

[José Antonio Olivera Ortega [:jaoo]]

Could you give a try and check whether the issue is gone please? Thanks!

Comment 7

[pgravel]

Verified the patch fixes the issue. Thanks for the quick turnaround!

Comment 8

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8365922 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/gaia/pull/15726

Fabien, after latest changes in cellular and data settings it seems we did not handle and store the custom APNs properly. This patch fix the issue and It has been also verified by the reporter. Could you take a look at it please? Thanks.

Comment 9

[Fabien Cazenave [:kaze]]

Comment on attachment 8365922 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/gaia/pull/15726

Your patch makes sense, thanks for the quick fix.

Let’s keep an eye on this fix, please: as I’m still waiting for my DSDS device, I can’t test this in a real dual-SIM situation.

Comment 10

[José Antonio Olivera Ortega [:jaoo]]

Thanks Fabien! Landed in Gaia master branch at https://github.com/mozilla-b2g/gaia/commit/40d05ad9377cc176e9cd097082ef78a73688e4b1

Comment 11

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 40d05ad9377cc176e9cd097082ef78a73688e4b1 to:
v1.3: 1b56ca5e1b7e001fd9aa5cded2b48da36cd38084