Closed
Bug 962938
Opened 10 years ago
Closed 10 years ago
Inconsistent file path in zip file
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: yurenju, Assigned: yurenju)
Details
Attachments
(1 file)
We have some file with "/" prefix for files in zip and others not, and we should use file separator "/" both on Windows & Linux but we currently use "\" on Windows. it's a regression after bug 957497 was landed.
|
||
Comment 1•10 years ago
|
||
Fix the bug and some error from jshint.
Attachment #8364912 -
Flags: review?(yurenju.mozilla)
|
Assignee | |
Comment 2•10 years ago
|
||
Comment on attachment 8364912 [details] [review] PR to master r=yurenju if you fix error from integration test
Attachment #8364912 -
Flags: review?(yurenju.mozilla) → review+
|
|
||
Comment 3•10 years ago
|
||
All green, thanks. https://github.com/mozilla-b2g/gaia/commit/d9c60b715a9d47d7cc97cdfc5ce4524ffc6a8d99
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 4•10 years ago
|
||
Revert commit since we got some problem for ringtones on bug 964805, I'll reland this after bug fixed, sorry for that. https://github.com/mozilla-b2g/gaia/commit/e9fdf382c56857492ebe0b85cf0a4ebe80a3c0a0
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 5•10 years ago
|
||
landed again. https://github.com/mozilla-b2g/gaia/commit/0f36ffef61592d32fff6206977328c637365f8f4
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•