Closed Bug 962954 Opened 6 years ago Closed 6 years ago

Add clang-format download for OSX

Categories

(Firefox Build System :: General, defect)

x86_64
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla29

People

(Reporter: ajones, Assigned: ajones)

References

Details

Attachments

(1 file, 1 obsolete file)

Upload OSX binary to people.mozilla.org/~ajones and modify clang-format downloader to match.
OS: Linux → Mac OS X
I built on OSX 10.8 and it didn't accept the static flag so I don't know what platforms my executable will run on.
(In reply to Anthony Jones (:kentuckyfriedtakahe, :k17e) from comment #2)
> I built on OSX 10.8 and it didn't accept the static flag so I don't know
> what platforms my executable will run on.

It runs fine on my Macbook Pro late 2013/OS X 10.9.1.
Attachment #8364165 - Flags: review?(gps) → review+
Depending on how much you update the remote binaries, we may want to hardcode hashes of the binaries to retrigger download of out-of-date binaries. But that's a followup.
(In reply to Gregory Szorc [:gps] from comment #4)
> Depending on how much you update the remote binaries, we may want to
> hardcode hashes of the binaries to retrigger download of out-of-date
> binaries. But that's a followup.

I figured we could suffix the binaries in some way. A hash or a version number or something would work. Hopefully we won't need to iterate too many times.
Note: the patch downloaded .mozbuild/clang-format-3.5-darwin, but mach wanted .mozbuild/clang-format-3.5, so it gave me OSError: [Errno 2] No such file or directory
I had to rename the file manually.
Attachment #8364165 - Attachment is obsolete: true
Comment on attachment 8366345 [details] [diff] [review]
Add clang-format downloading support for OSX;

Review of attachment 8366345 [details] [diff] [review]:
-----------------------------------------------------------------

::: tools/mach_commands.py
@@ +336,4 @@
>                  return 1
>  
>          os.chdir(self.topsrcdir)
> +        self.prompt = 1

Can you just change this to True (and False) below. I missed this in the original review.
Attachment #8366345 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/4a1e002cb3c2
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.