962954 - Add clang-format download for OSX

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Upload OSX binary to people.mozilla.org/~ajones and modify clang-format downloader to match.

Comment 1

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Attachment: Add clang-format downloading support for OSX;

Comment 2

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

I built on OSX 10.8 and it didn't accept the static flag so I don't know what platforms my executable will run on.

Comment 3

[John Lin [:jhlin][:jolin]]

(In reply to Anthony Jones (:kentuckyfriedtakahe, :k17e) from comment #2)
> I built on OSX 10.8 and it didn't accept the static flag so I don't know
> what platforms my executable will run on.

It runs fine on my Macbook Pro late 2013/OS X 10.9.1.

Comment 4

[Gregory Szorc [:gps]]

Depending on how much you update the remote binaries, we may want to hardcode hashes of the binaries to retrigger download of out-of-date binaries. But that's a followup.

Comment 5

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

(In reply to Gregory Szorc [:gps] from comment #4)
> Depending on how much you update the remote binaries, we may want to
> hardcode hashes of the binaries to retrigger download of out-of-date
> binaries. But that's a followup.

I figured we could suffix the binaries in some way. A hash or a version number or something would work. Hopefully we won't need to iterate too many times.

Comment 6

[Valentin Gosu [:valentin] (he/him)]

Note: the patch downloaded .mozbuild/clang-format-3.5-darwin, but mach wanted .mozbuild/clang-format-3.5, so it gave me OSError: [Errno 2] No such file or directory
I had to rename the file manually.

Comment 7

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Attachment: Add clang-format downloading support for OSX;

Comment 8

[Gregory Szorc [:gps]]

Comment on attachment 8366345 [details] [diff] [review]
Add clang-format downloading support for OSX;

Review of attachment 8366345 [details] [diff] [review]:
-----------------------------------------------------------------

::: tools/mach_commands.py
@@ +336,4 @@
>                  return 1
>  
>          os.chdir(self.topsrcdir)
> +        self.prompt = 1

Can you just change this to True (and False) below. I missed this in the original review.

Comment 9

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4a1e002cb3c2

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4a1e002cb3c2