963014 - Remove hacks used to dismiss update-checker

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Florin Strugariu [:Bebe]]

Now that bug 879192 is fixed we can start removing 

https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/apps/browser/app.py#L46

Comment 1

[Viorela Ioia [:viorela]]

Attachment: Github PR: https://github.com/mozilla-b2g/gaia/pull/15647

Comment 2

[[:AndreiH]]

Thanks for taking this viorela. This works nicely!

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8364324 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/15647

I thought we had this workaround in more places, but I double checked and apparently not! Thanks Viorela for the quick patch - there's just a minor update needed. I'd also like to see a passing adhoc build before we merge.

Comment 4

[Viorela Ioia [:viorela]]

I updated the PR, and here's the adhoc run with browser tests: http://qa-selenium.mv.mozilla.com:8080/view/B2G%20Hamachi/job/b2g.hamachi.mozilla-central.ui.adhoc/121/console

Comment 5

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8364324 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/15647

Great, thanks Viorela! Landed in:
https://github.com/mozilla-b2g/gaia/commit/ca5d9bba319f6d6564c9b162f92cab7bf9349758