Closed Bug 963021 Opened 6 years ago Closed 6 years ago
[Messages][Refresh] Add CSS tweaks for SMS based on new List component from BB
Due to the new styles of the list, we need to add the tweaks needed for SMS App.
VD refresh issues are not blockers for the release, so not blocking.
blocking-b2g: 1.4? → backlog
Assignee: joan.leon → arnau
After Applying patch: https://github.com/mozilla-b2g/gaia/pull/17888 we get that screen, so we need to remove the rounded border in empty images.
Comment on attachment 8410927 [details] [review] patch in github looks good but would look better with a unit test ;)
Attachment #8410928 - Flags: ui-review?(vpg) → ui-review+
Comment on attachment 8410927 [details] [review] patch in github As promised, I added a unit test for this function. I didn't add tests for everything the function does, only for what you added. Writing unit tests, I found some issues, so I commented about them :) Then you can ask review from borja or Steve. Thanks !
Target Milestone: 1.4 S6 (25apr) → 2.0 S1 (9may)
Comment on attachment 8410927 [details] [review] patch in github Some comments in Github. Ask me to review this again when ready! Thanks!
Comment on attachment 8410927 [details] [review] patch in github Could you please review it again? PR updated with your comments in GH.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Attachment #8410927 - Flags: review?(borja.bugzilla) → review+
Tested 1.5 Hamachi Gecko:177f146 Gaia:4788795
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.