963034 - AArch64 support for toolkit

Status: RESOLVED INVALID

(Toolkit :: Crash Reporting, defect)

Description

[Marcin Juszkiewicz]

Attachment: aarch64-toolkit.patch

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:29.0) Gecko/20100101 Firefox/29.0 (Beta/Release)
Build ID: 20140122030521

Comment 1

[(not currently active) Ted Mielczarek]

Comment on attachment 8364282 [details] [diff] [review]
aarch64-toolkit.patch

Review of attachment 8364282 [details] [diff] [review]:
-----------------------------------------------------------------

So first things first, the Breakpad source is imported wholesale from an upstream Google code project, so fixes really need to go there first:
https://code.google.com/p/google-breakpad/

Second, this really isn't going to do anything. We shouldn't be building this code at all unless we have a full Breakpad port for Linux/AArch64. If we're building this code then you should be patching configure instead to stop building it in this configuration:
http://mxr.mozilla.org/mozilla-central/source/configure.in#5900

A Breakpad port would be useful if you're intending on shipping Firefox in this configuration, but it's probably not critical at this point. Breakpad does already have code in place to support arm64 on the backend (for newer iPhones):
https://code.google.com/p/google-breakpad/source/browse/trunk/src/google_breakpad/common/minidump_cpu_arm64.h

so I assume a Linux port wouldn't be a lot of work, mostly just fixing the client side to shuffle register state around as appropriate.

Comment 2

[Marcin Juszkiewicz]

LG_QUANTUM part is in google-breakpad for quite long time:

commit daf6d0446ce64fb563b7d96fda077e6406c602be
Author: Riku Voipio <[e-mail]>
Date:   Mon Mar 18 16:40:20 2013 +0200

    Add aarch64 LG_QUANTUM size definition
    
    Signed-off-by: Riku Voipio <[e-mail]>

But you are right. I will drop that patch from my patchset.

Comment 3

[(not currently active) Ted Mielczarek]

I can't find that commit you're referencing, are you sure that's Breakpad?

Comment 4

[Marcin Juszkiewicz]

Oops, wrong tab. sorry - it was jemalloc.

Comment 5

[Marcin Juszkiewicz]

Closing for now - when Breakpad will be ported to aarch64-gnu-linux then proper request will be done.

Comment 6

[(not currently active) Ted Mielczarek]

FYI upstream is working on some AArch64 support:
https://code.google.com/p/google-breakpad/source/detail?r=1301