963039 - [B2G][Settings] Developer settings are too hard to access

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Jan Keromnes [:janx]]

Currently, to reach the developer settings, one has to follow this path:

> Settings (scroll down) > Device Information > More Information (scroll down) > Developer

This is tedious and doesn't make any sense. Instead, the developer settings should be easier to reach:

> Settings (scroll down) > Developer Options

I understand that there are concerns with making the Developer Options too discoverable. I personally don't share said concerns, and think it great to encourage people to tinker with their phone, but these concerns can be alleviated by requiring a "developer mode" to enable the developer settings:
- Android does this by asking users to tap repeatedly on About phone > Build number to activate "developer mode".
- We could hide a "Enable developer mode" checkbox where the current Developer menu is.

Comment 1

[Paul Rouget [:paul]]

> We could hide a "Enable developer mode" checkbox where the current Developer menu is.

I like that.

Settings > Device Information > More Information > Enable Developer Menu [ ]

Then directly in Settings, we'd see:

Settings > Developer > all the developer related items

I think it's worth sharing this on the dev-gaia mailing list.

Comment 2

[Jan Keromnes [:janx]]

Attachment: pull request

- Move the developer settings from `Settings > Device Information > More Information > Developer` to `Settings > Developer`.
- Show/hide the developer settings depending on the `Settings > Device Information > More Information > Developer menu` checkbox (pref `developer.menu.enabled`).

FIXME:
- Developer menu shouldn't have the same icon as Accessibility.
- Tests?

Comment 3

[Jan Keromnes [:janx]]

vingtetun:
- I used the same pref as your Developer menu in the Sleep Menu, does that make sense?
- Where do I get a new icon for Settings > Developer?
- Should this menu have tests?

Comment 4

[[e-mail]]

needinfo UX feedback for Settings UI change

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Jan Keromnes [:janx] from comment #3)
> vingtetun:
> - I used the same pref as your Developer menu in the Sleep Menu, does that
> make sense?

That makes sense.

> - Where do I get a new icon for Settings > Developer?

What Fred Lin did.

> - Should this menu have tests?

Tests are always nice :)

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8365831 [details] [review]
pull request

Looks good to me.

Comment 7

[Jan Keromnes [:janx]]

Evelyn, could you please review my change?

Apart from a new icon for the Developer menu (pending firefoxos-ux' needinfo) everything is there and Travis is green. As a bonus, I also fixed the Developer menu to pass the new JSHint checks.

Comment 8

[Stephany Wilkes]

Flagging Neo, who is UX on Settings.

Comment 9

[Jan Keromnes [:janx]]

Good suggestions from Kevin Grandon in order not to make some workflows harder:
1 - Turn on by default for non-production builds in our build scripts.
2 - Consider navigating to the panel when the user enables the option.

Comment 10

[Neo Hsieh [:neo]]

Hi Jan, Thanks for your suggestion. 
Consider of our FFOS phone have many power users and developers. 
I think if we can have a toggle to switch "Developer settings" show on top level bottom or not, that will be good for this part of users. But this toggle should not in top level. I think maybe in "Device information--> Developer settings (On/Off)" . This item will after "Last Updated" item.  
What do you think ? 

And I still need to discuss this topic with our PM. I will need inform him and ask for his comment.

Comment 11

[Jan Keromnes [:janx]]

Hi Neo, thanks for your feedback!
Currently in my patch, the suggested toggle is not in top level, but in "Device information > More information > Developer menu (On/Off)". Are you suggesting that we move that toggle one level up to "Device information > Developer menu (On/Off)"? Both ways are fine with me.

Comment 12

[Evelyn Hung]

Comment on attachment 8365831 [details] [review]
pull request

Thanks for the patch, it looks good to me, but there are two things I concern:
1. we need UX's confirm on this change. (Neo is jumping in since comment 10)
2. should "developer.menu.enabled" be default off on production(user) build?

Comment 13

[Joe Cheng [:jcheng] (please needinfo)]

as long as we have UX agreed upon, its definitely fine to change it. we do not need to wait for this to get into the release roadmap to change it

Comment 14

[Jan Keromnes [:janx]]

Comment on attachment 8365831 [details] [review]
pull request

Thank you Evelyn for the review!

> 1. we need UX's confirm on this change. (Neo is jumping in since comment 10)

As Joe said, since UX agreed, there is no need to wait for this to get into the release roadmap. Neo, can you please confirm?

> 2. should "developer.menu.enabled" be default off on production(user) build?

Yes, this is off by default on production(user) builds.

Comment 15

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8365831 [details] [review]
pull request

My understanding of comment #10 is that Neo is fine with that as long as the toggle is not at the top level. The toggle is hidden here under 4 level of panels so that sounds good to me.

Also by default the developer menu is hidden for production build, which seems great.

So r+'ing with one nit about the change in the accessibility.html part that should not be part of this PR.

Neo, If I misunderstood what you were saying or if some of your concerns were not expressed feel free to reopened the bug or to fill a followup in order to address anything that comes to your mind.

Comment 16

[Fernando Jiménez Moreno [:ferjm]]

https://github.com/mozilla-b2g/gaia/pull/15713

Comment 17

[Jan Keromnes [:janx]]

This change breaks the developer documentation, because the "Developer" menu, along with all the developer settings, moved to "Settings > Developer" instead of "Settings > Device information > More info > Developer".

Comment 18

[Neo Hsieh [:neo]]

Sure, That's a good idea for so many developers. I just need PM & SW 's confirm . Let's do it.

Comment 19

[Jan Keromnes [:janx]]

Thanks a lot Neo! Could you please confirm when you hear about your PM & SW?

Also, the Developer menu needs a new icon. Are you the right person to ask for this?

Comment 20

[[e-mail]]

Harly, could you help on this or find the right person to do so?

Comment 21

[Harly Hsu[:harly]]

Needinfo Omega, as he will be taking over Settings now.

Hi Omega, could you take a look at this, thank!

Comment 22

[Omega Feng [:Omega] [:馮於懋]]

Hi Carol, need your help on the Developer icon in Settings.

Comment 23

[Carol Huang [:Carol]]

Attachment: Sprite.zip

The attachment is Sprite for Developer icon update! thanks!

Comment 24

[Jan Keromnes [:janx]]

Attachment: update settings sprite in gaia

Great icon, thanks Carol!

Evelyn, I updated the sprites in Gaia, please take a look.

Comment 25

[Jan Keromnes [:janx]]

Comment on attachment 8378782 [details] [review]
update settings sprite in gaia

(Let's move this pull request to bug #968454)