Closed Bug 963041 Opened 9 years ago Closed 9 years ago

Console API in workers should use the queueCall exposed by Console API webIDL

Categories

(Core :: DOM: Core & HTML, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: baku, Assigned: baku)

References

Details

Attachments

(1 file, 2 obsolete files)

This can be done only when bug 629607 is resolved.
Depends on: 620935
Attached patch consoleB.patch (obsolete) — Splinter Review
Of course this patch is meant to be applied on top of Console ported to WebIDL
Attachment #8364463 - Flags: review?(bzbarsky)
Comment on attachment 8364463 [details] [diff] [review]
consoleB.patch

Why do you need the ConsoleProxy?  It used to be needed to cache the per-window JS object we created, but can't you just do wp->GetWindow()->Console() now?
(In reply to Boris Zbarsky [:bz] from comment #2)
> Comment on attachment 8364463 [details] [diff] [review]
> consoleB.patch
> 
> Why do you need the ConsoleProxy?  It used to be needed to cache the
> per-window JS object we created, but can't you just do
> wp->GetWindow()->Console() now?

Right.
Attached patch consoleB.patch (obsolete) — Splinter Review
Attachment #8364463 - Attachment is obsolete: true
Attachment #8364463 - Flags: review?(bzbarsky)
Attachment #8364508 - Flags: review?(bzbarsky)
Comment on attachment 8364508 [details] [diff] [review]
consoleB.patch

>+  void queueCall(DOMString method, any arguments, optional any stack);

I don't see any reason for that last arg to be optional.

r=me with that nixed, thanks!
Attachment #8364508 - Flags: review?(bzbarsky) → review+
Attached patch consoleB.patchSplinter Review
Attachment #8364508 - Attachment is obsolete: true
Implemented in bug 965860
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Depends on: 965860
Target Milestone: --- → mozilla30
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.