Console API in workers should use the queueCall exposed by Console API webIDL

RESOLVED FIXED in mozilla30

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: baku, Assigned: baku)

Tracking

Trunk
mozilla30
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 years ago
This can be done only when bug 629607 is resolved.
(Assignee)

Updated

5 years ago
Depends on: 620935
(Assignee)

Comment 1

5 years ago
Created attachment 8364463 [details] [diff] [review]
consoleB.patch

Of course this patch is meant to be applied on top of Console ported to WebIDL
Attachment #8364463 - Flags: review?(bzbarsky)
Comment on attachment 8364463 [details] [diff] [review]
consoleB.patch

Why do you need the ConsoleProxy?  It used to be needed to cache the per-window JS object we created, but can't you just do wp->GetWindow()->Console() now?
(Assignee)

Comment 3

5 years ago
(In reply to Boris Zbarsky [:bz] from comment #2)
> Comment on attachment 8364463 [details] [diff] [review]
> consoleB.patch
> 
> Why do you need the ConsoleProxy?  It used to be needed to cache the
> per-window JS object we created, but can't you just do
> wp->GetWindow()->Console() now?

Right.
(Assignee)

Comment 4

5 years ago
Created attachment 8364508 [details] [diff] [review]
consoleB.patch
Attachment #8364463 - Attachment is obsolete: true
Attachment #8364463 - Flags: review?(bzbarsky)
Attachment #8364508 - Flags: review?(bzbarsky)
Comment on attachment 8364508 [details] [diff] [review]
consoleB.patch

>+  void queueCall(DOMString method, any arguments, optional any stack);

I don't see any reason for that last arg to be optional.

r=me with that nixed, thanks!
Attachment #8364508 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 6

5 years ago
Created attachment 8364537 [details] [diff] [review]
consoleB.patch
Attachment #8364508 - Attachment is obsolete: true
(Assignee)

Comment 7

4 years ago
Implemented in bug 965860
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Depends on: 965860
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.