963041 - Console API in workers should use the queueCall exposed by Console API webIDL

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andrea Marchesini [:baku]]

This can be done only when bug 629607 is resolved.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: consoleB.patch

Of course this patch is meant to be applied on top of Console ported to WebIDL

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8364463 [details] [diff] [review]
consoleB.patch

Why do you need the ConsoleProxy?  It used to be needed to cache the per-window JS object we created, but can't you just do wp->GetWindow()->Console() now?

Comment 3

[Andrea Marchesini [:baku]]

(In reply to Boris Zbarsky [:bz] from comment #2)
> Comment on attachment 8364463 [details] [diff] [review]
> consoleB.patch
> 
> Why do you need the ConsoleProxy?  It used to be needed to cache the
> per-window JS object we created, but can't you just do
> wp->GetWindow()->Console() now?

Right.

Comment 4

[Andrea Marchesini [:baku]]

Attachment: consoleB.patch

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8364508 [details] [diff] [review]
consoleB.patch

>+  void queueCall(DOMString method, any arguments, optional any stack);

I don't see any reason for that last arg to be optional.

r=me with that nixed, thanks!

Comment 6

[Andrea Marchesini [:baku]]

Attachment: consoleB.patch

Comment 7

[Andrea Marchesini [:baku]]

Implemented in bug 965860