963064 - FileHandle cleanup

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jan Varga [:janv]]

Attachment: patch

- remove nsIDOMFileHandle interface
- remove DOMFileHandle.h/.cpp and change FileHandle.h/.cpp to provide a default FileHandle implementation
- related code style cleanup

Comment 1

[Jan Varga [:janv]]

Attachment: rebased patch

Comment 2

[Jan Varga [:janv]]

https://tbpl.mozilla.org/?tree=Try&rev=10d9253d82ea

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 8368501 [details] [diff] [review]
rebased patch

Review of attachment 8368501 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, sorry this took so long!

::: dom/file/FileHandle.cpp
@@ +74,2 @@
>  
> +  nsRefPtr<FileHandle> newFileHandle(new FileHandle(aWindow));

Nit: Use = instead.

@@ +117,2 @@
>  {
> +  nsCOMPtr<nsIDOMFile> file = 

Nit: whitespace

::: dom/file/FileHandle.h
@@ +87,3 @@
>    virtual already_AddRefed<nsISupports>
> +  CreateStream(nsIFile* aFile, bool aReadOnly);
> + 

Nit: whitespace

Comment 4

[Jan Varga [:janv]]

thanks, nits fixed

https://hg.mozilla.org/integration/mozilla-inbound/rev/90b514d09591

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/90b514d09591