Closed Bug 963064 Opened 6 years ago Closed 6 years ago

FileHandle cleanup

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: janv, Assigned: janv)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
- remove nsIDOMFileHandle interface
- remove DOMFileHandle.h/.cpp and change FileHandle.h/.cpp to provide a default FileHandle implementation
- related code style cleanup
Attachment #8364312 - Attachment is patch: true
Attachment #8364312 - Flags: feedback?(Ms2ger)
Blocks: 942542
Attached patch rebased patchSplinter Review
Assignee: nobody → Jan.Varga
Attachment #8364312 - Attachment is obsolete: true
Attachment #8364312 - Flags: feedback?(Ms2ger)
Attachment #8368501 - Flags: review?(bent.mozilla)
Comment on attachment 8368501 [details] [diff] [review]
rebased patch

Review of attachment 8368501 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, sorry this took so long!

::: dom/file/FileHandle.cpp
@@ +74,2 @@
>  
> +  nsRefPtr<FileHandle> newFileHandle(new FileHandle(aWindow));

Nit: Use = instead.

@@ +117,2 @@
>  {
> +  nsCOMPtr<nsIDOMFile> file = 

Nit: whitespace

::: dom/file/FileHandle.h
@@ +87,3 @@
>    virtual already_AddRefed<nsISupports>
> +  CreateStream(nsIFile* aFile, bool aReadOnly);
> + 

Nit: whitespace
Attachment #8368501 - Flags: review?(bent.mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/90b514d09591
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.