963085 - Subscribe subview doesn't have an header

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[u428464]

Unlike other subviews, the "subscribe" one doesn't have an header.

Comment 1

[Mike de Boer [:mikedeboer]]

Guillaume, can you give a URL that you test this with? I don't know ANY site that offers more than two feeds :/

Comment 2

[u428464]

(In reply to Mike de Boer [:mikedeboer] from comment #1)
> Guillaume, can you give a URL that you test this with? I don't know ANY site
> that offers more than two feeds :/

http://www.lequipe.fr/ for example ;)

Comment 3

[Mike de Boer [:mikedeboer]]

Attachment: Patch v1: add header to Subscribe menu

Requires adding a string...

Comment 4

[Mike de Boer [:mikedeboer]]

Attachment: Patch v1.1: add header to Subscribe menu

forgot to remove a line used for testing.

Comment 5

[Mike de Boer [:mikedeboer]]

Just to have this documented somewhere: http://www.nu.nl/ also has multiple feeds, so now we have two!

Comment 6

[Mike de Boer [:mikedeboer]]

Thanks!

remote: https://hg.mozilla.org/integration/fx-team/rev/3e47c6473118

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3e47c6473118

Comment 8

[Cornel Ionce [:noni] [Hubs QA]]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:29.0) Gecko/20100101 Firefox/29.0
Mozilla/5.0 (X11; Linux i686; rv:29.0) Gecko/20100101 Firefox/29.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0

Verified fixed on Firefox 29 beta 5 (build ID: 20140403132807).