Deploy Fireplace feed branch to -dev, -stage

RESOLVED FIXED

Status

P2
normal
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: chuck, Assigned: jason)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

5 years ago
Could we set up the feed branch of the Fireplace repository for deployment to both -dev and -stage and served at /feed?

https://github.com/mozilla/fireplace/tree/feed

Configuration should be identical to the -dev and -stage instances of Fireplace, with the exception of media_url, which should bring in the same folders of static media in the same way as the normal deployment of Fireplace, only serving media from that branch.

This should not be deployed to production.

Thanks!
Is this just a temporary thing, which will be merged back in to master, or a forked code base on this branch?
Flags: needinfo?(charmston)
(Reporter)

Comment 2

5 years ago
It's temporary. We'll eventually merge it into master, but it will be a group of changes that we're unable to make incrementally as we typically try to do.
Flags: needinfo?(charmston)
Assignee: server-ops → oremj
Pushed out to dev/stage @ /media/feed/. Dev will auto update off the commit hook. Stage will need to be pushed via dreadnot.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Reporter)

Comment 5

5 years ago
This doesn't appear to be working as expected. The feed branch has a commit that substantially changes both templates and static files, and neither appear to be updated on https://marketplace-feed-dev.allizom.org :

https://github.com/mozilla/fireplace/compare/b9baa09f21a0...1d4240e0ab29

Would you mind looking into this, Jason?
Assignee: oremj → jthomas
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Updated

5 years ago
Blocks: 957299
(Assignee)

Updated

5 years ago
Priority: -- → P2
(Assignee)

Comment 6

5 years ago
-dev should be working now. stage will be fixed once https://github.com/mozilla/zamboni/commit/ee55c2c53a17eed5222aaec42c6a51c9aca99fb9 lands on stage.
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
(Reporter)

Comment 7

5 years ago
I'm not sure this is quite working yet. I'm getting a 404 on some of the CSS on -dev:

https://marketplace-feed-dev.allizom.org/
https://marketplace-feed-dev-cdn.allizom.org/media/fireplace/css/splash.styl.css?b=1394844001572
(Reporter)

Updated

5 years ago
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 8

5 years ago
I see /hearth/media/css/splash.styl on the file system but not ./hearth/media/css/splash.styl.css. How does this file get generated?
(Reporter)

Comment 9

5 years ago
This is the code that does it: https://github.com/mozilla/commonplace/blob/master/lib/build.js#L176-L193

I'm not exactly sure how that fits into the deploy process as a whole.
(Assignee)

Comment 10

5 years ago
Do we need commonplace@0.2.8 here? Right now the feed branch is pinned to 0.2.6
(Assignee)

Comment 11

5 years ago
I tested with commonplace@0.2.8 and it seems like it generated the file. master is currently using 0.2.8, can we update the feed branch to use this as well? https://github.com/mozilla/fireplace/blob/master/fabfile.py#L27
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
Updated
Component: Server Operations: AMO Operations → Operations: Marketplace
Product: mozilla.org → Mozilla Services
You need to log in before you can comment on or make changes to this bug.