963153 - Firefox Accounts (Sync) - Sync failed: java.lang.IllegalArgumentException sync.prefs.org!mozilla!fennec!fxa.$.https://api-accounts-onepw.dev.lcip.org.1.xml contains a path separator

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: Android Sync, defect)

Description

[Aaron Train [:aaronmt]]

I/FxAccounts( 6931): fennec :: FxAccountSyncAdapter :: Syncing FxAccount account named myemail for authority org.mozilla.fennec.db.browser with instance org.mozilla.gecko.fxa.sync.FxAccountSyncAdapter@430c8f58.
I/FxAccounts( 6931): fennec :: AndroidFxAccount :: $$FxA PII$$: email: myemail
I/FxAccounts( 6931): fennec :: AndroidFxAccount :: $$FxA PII$$: emailUTF8: 6161726f6e2e747261696e40676d61696c2e636f6d
I/FxAccounts( 6931): fennec :: AndroidFxAccount :: $$FxA PII$$: keyFetchToken: 97f5f52bdd0856b2c1ebfa2fd3e4417a3eef581c697878f9f922f657eadee6b8
I/FxAccounts( 6931): fennec :: AndroidFxAccount :: $$FxA PII$$: quickStretchedPW: 2ba9a593cd8786de9daafb72f016d9ce8ddbec83f660e5dcf0ee739902151c12
I/FxAccounts( 6931): fennec :: AndroidFxAccount :: $$FxA PII$$: sessionToken: 16e2638eb7a0c1d9451f263d9d9c4bb56b9bba0433416b866c0e54c87d98283c
I/FxAccounts( 6931): fennec :: AndroidFxAccount :: $$FxA PII$$: unwrapkB: feb3bb4632fb514081397928297ee436f2bf8a2c18aaef58ac15d093b8456470
I/FxAccounts( 6931): fennec :: AndroidFxAccount :: $$FxA PII$$: verified: true
I/FxAccounts( 6931): fennec :: AndroidFxAccount :: $$FxA PII$$: version: 1
E/FxAccounts( 6931): fennec :: FxAccountSyncAdapter :: Got error syncing.
E/FxAccounts( 6931): java.lang.IllegalArgumentException: File sync.prefs.org!mozilla!fennec!fxa.ytcj4ypbypijz6tosw6bo2t77ltbmvhr.https://api-accounts-onepw.dev.lcip.org.1.xml contains a path separator
E/FxAccounts( 6931):    at android.app.ContextImpl.makeFilename(ContextImpl.java:2172)
E/FxAccounts( 6931):    at android.app.ContextImpl.getSharedPrefsFile(ContextImpl.java:755)
E/FxAccounts( 6931):    at android.app.ContextImpl.getSharedPreferences(ContextImpl.java:785)
E/FxAccounts( 6931):    at android.content.ContextWrapper.getSharedPreferences(ContextWrapper.java:173)
E/FxAccounts( 6931):    at org.mozilla.gecko.fxa.sync.FxAccountSyncAdapter.onPerformSync(FxAccountSyncAdapter.java:172)
E/FxAccounts( 6931):    at android.content.AbstractThreadedSyncAdapter$SyncThread.run(AbstractThreadedSyncAdapter.java:259)
W/FxAccounts( 6931): fennec :: FxAccountSyncAdapter :: Sync failed.
W/FxAccounts( 6931): java.lang.IllegalArgumentException: File sync.prefs.org!mozilla!fennec!fxa.ytcj4ypbypijz6tosw6bo2t77ltbmvhr.https://api-accounts-onepw.dev.lcip.org.1.xml contains a path separator
W/FxAccounts( 6931):    at android.app.ContextImpl.makeFilename(ContextImpl.java:2172)
W/FxAccounts( 6931):    at android.app.ContextImpl.getSharedPrefsFile(ContextImpl.java:755)
W/FxAccounts( 6931):    at android.app.ContextImpl.getSharedPreferences(ContextImpl.java:785)
W/FxAccounts( 6931):    at android.content.ContextWrapper.getSharedPreferences(ContextWrapper.java:173)
W/FxAccounts( 6931):    at org.mozilla.gecko.fxa.sync.FxAccountSyncAdapter.onPerformSync(FxAccountSyncAdapter.java:172)
W/FxAccounts( 6931):    at android.content.AbstractThreadedSyncAdapter$SyncThread.run(AbstractThreadedSyncAdapter.java:259)
E/FxAccounts( 6931): fennec :: FxAccountSyncAdapter :: Syncing done.
D/SyncManager(  706): failed sync operation myemail u0 (org.mozilla.fennec_account), org.mozilla.fennec.db.browser, SERVER, latestRunTime 5620035, reason: IsSyncable, SyncResult: stats [ numIoExceptions: 1 numUpdates: 1]

Spotted this in console on sign-in on Nightly (01/23).

--
Nightly (01/23)
Samsung Galaxy SIV (Android 4.4.2)

Comment 1

[Nick Alexander :nalexander [he/him]]

Hmm, I was seeing this in my testing but it was because I had a bug in my code (that hasn't yet landed).  This is just a mis-configured account; if you can repeat with a new account, we have parameter ordering problems.  I expect this to be squashed by tomorrow's nightly.

Comment 2

[Aaron Train [:aaronmt]]

Sounds good; setting a reminder.

Comment 3

[Richard Newman [:rnewman]]

We do use the account server URI in the prefs specifier -- that is, settings depend on the (email, server, app, profile) triple.

This is probably a legitimate bug, unless we fixed it by accident.

I presume you're testing Nightly, not services-central, Aaron?

Comment 4

[Nick Alexander :nalexander [he/him]]

(In reply to Richard Newman [:rnewman] from comment #3)
> We do use the account server URI in the prefs specifier -- that is, settings
> depend on the (email, server, app, profile) triple.
> 
> This is probably a legitimate bug, unless we fixed it by accident.
> 
> I presume you're testing Nightly, not services-central, Aaron?

Somewhere in the mess the server gets hashed.  I was hitting this because I reversed some constructor args.

Comment 5

[Aaron Train [:aaronmt]]

Re comment #3; Nightly (M-C)

Comment 6

[Richard Newman [:rnewman]]

Squashed?

Comment 7

[Aaron Train [:aaronmt]]

Squashed.