96318 - Font download dialog does not show up

Status: VERIFIED FIXED

Description

[Teruko Kobayashi]

Font download dialog does not show up on Win98 and WinME.

Steps of reproduce
1. Delete Japanese fonts in the Windows system
2. Go to http://home.netscape.com/ja

Font Download dialog does not show up.

Tested 8-21-11 trunk Win32 build on Win98 US and WinME US system.

Comment 1

[Frank Tang]

if you open preference:font and select Japanese encoding, do you see any font
list there?

Comment 2

[Teruko Kobayashi]

I do not see any Japanese fonts in the preferences.  I checked in system font 
directory.  No CJK fonts are installed in the system.

Comment 3

[Frank Tang]

moz0.9.5

Comment 4

[Andreas Becker]

ftang, can we move this one to m0.9.4?  It is a regression (e.g. broken on
Win98) and I think that this is a critical bug for this milestone release.

Comment 5

[Frank Tang]

how many people will "Delete Japanese fonts in the Windows system" ? 

Comment 6

[Teruko Kobayashi]

Frank, this is not for only Japanese font.  This is general font download 
problem.  Font download dialog does not show for Korean and Chinese, either.  

Also, I am using US system. Basically, the US machine user does not have CJK 
fonts.  

Comment 7

[Frank Tang]

ok, a lot of misunderstand in this bug
Teruko really mean the font download does not work in any case, not just AFTER
user remove their isntalled font:
>Steps of reproduce
>1. Delete Japanese fonts in the Windows system
>2. Go to http://home.netscape.com/ja
should really be

user remove their isntalled font:
>Steps of reproduce
>1. Make sure there are no Japanese font in the system, if any, remove them.
>2. Go to http://home.netscape.com/ja

I thought she mean this bug only happen if user have install font once and then
remove them. 

roy- can you take a look at it ? seems pretty bad. 

Comment 8

[Roy Yokoyama]

It appears that it works with mozilla 0_9_2_BRANCH build; but not working with current trunk.

Comment 9

[Roy Yokoyama]

CheckFontLangGroup()  in //gfx/windows/nsFontMetricsWin.cpp asserts at line 335

331     if (!have) {
332       nsresult res = NS_OK;
334       nsCOMPtr<nsIFontPackageProxy> proxy = do_GetService("@mozilla.org/intl/fontpackageservice;1", &res);
335       NS_ASSERTION(NS_SUCCEEDED(res), "cannot get the font package proxy");
336       NS_ASSERTION(proxy, "cannot get the font package proxy");

I checked the //locale/nsLocaleDLL.cpp to see if the FontPackageService is registered.
The file doesn't contain FontPackageService anymore.  It has been accidently (?) removed by waterson
Bug 94831. Convert locale stuff to generic module. /r=ftang

I'll post a match to add the FontPackageService back.

Comment 10

[Roy Yokoyama]

Created attachment 47913 [details] [diff] [review]
Redefining nsFontPackageService

Comment 11

[Roy Yokoyama]

ftang/waterson: can you review and super review the patch?

Comment 12

[Frank Tang]

read cvs log of mozilla/ intl/ locale/ src/ windows/ nsLocaleDLL.cpp (1.23)

1.23waterson%netscape.comAug 16 22:52 Bug 94831. Convert locale stuff to generic
module. r/sr=nobody: I am the devil.

r=ftang
Mr. devil (waterson), can you sr this one ? :)

Comment 13

[Chris Waterson]

sr=waterson. Do we need to do anything on Unix, OS/2, or Mac?

Comment 14

[Roy Yokoyama]

waterson: >Do we need to do anything on Unix, OS/2, or Mac?
Not at the moment; however, we may want to support the font downloading 
for other platforms in near future. :)

Comment 15

[Roy Yokoyama]

adding the topembed keyword. We need to check into 0_9_2_BRANCH tree.

Comment 16

[Teruko Kobayashi]

I checked this in 8-30 0.9.2 build. This does not work in the build, either.

Comment 17

[Roy Yokoyama]

checked into 0_9_2_BRANCH

Comment 18

[Asa Dotzler [:asa]]

Comment on attachment 47913 [details] [diff] [review]
Redefining nsFontPackageService

a=asa for checkin to the 0.9.4 branch

Comment 19

[Roy Yokoyama]

checked into 0_9_4_BRANCH and the trunk

Comment 20

[Teruko Kobayashi]

Verified as fixed in 09-06-0.9.2ec, 09-07-05-0.9.4 and 09-07-09 Win 32 trunk 
build.