If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Font download dialog does not show up

VERIFIED FIXED in mozilla0.9.4

Status

()

Core
Internationalization
VERIFIED FIXED
16 years ago
16 years ago

People

(Reporter: Teruko Kobayashi, Assigned: Roy Yokoyama)

Tracking

({intl, regression, topembed})

Trunk
mozilla0.9.4
x86
Windows 98
intl, regression, topembed
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

16 years ago
Font download dialog does not show up on Win98 and WinME.

Steps of reproduce
1. Delete Japanese fonts in the Windows system
2. Go to http://home.netscape.com/ja

Font Download dialog does not show up.

Tested 8-21-11 trunk Win32 build on Win98 US and WinME US system.
(Reporter)

Updated

16 years ago
Keywords: intl
QA Contact: andreasb → teruko

Updated

16 years ago
Keywords: nsbranch, regression

Comment 1

16 years ago
if you open preference:font and select Japanese encoding, do you see any font
list there?
(Reporter)

Comment 2

16 years ago
I do not see any Japanese fonts in the preferences.  I checked in system font 
directory.  No CJK fonts are installed in the system.

Comment 3

16 years ago
moz0.9.5
Target Milestone: --- → mozilla0.9.5

Comment 4

16 years ago
ftang, can we move this one to m0.9.4?  It is a regression (e.g. broken on
Win98) and I think that this is a critical bug for this milestone release.

Comment 5

16 years ago
how many people will "Delete Japanese fonts in the Windows system" ? 
(Reporter)

Comment 6

16 years ago
Frank, this is not for only Japanese font.  This is general font download 
problem.  Font download dialog does not show for Korean and Chinese, either.  

Also, I am using US system. Basically, the US machine user does not have CJK 
fonts.  

Comment 7

16 years ago
ok, a lot of misunderstand in this bug
Teruko really mean the font download does not work in any case, not just AFTER
user remove their isntalled font:
>Steps of reproduce
>1. Delete Japanese fonts in the Windows system
>2. Go to http://home.netscape.com/ja
should really be

user remove their isntalled font:
>Steps of reproduce
>1. Make sure there are no Japanese font in the system, if any, remove them.
>2. Go to http://home.netscape.com/ja

I thought she mean this bug only happen if user have install font once and then
remove them. 

roy- can you take a look at it ? seems pretty bad. 
Assignee: ftang → yokoyama
Keywords: nsbranch+
Target Milestone: mozilla0.9.5 → mozilla0.9.4
(Assignee)

Comment 8

16 years ago
It appears that it works with mozilla 0_9_2_BRANCH build; but not working with current trunk.
(Assignee)

Updated

16 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 9

16 years ago
CheckFontLangGroup()  in //gfx/windows/nsFontMetricsWin.cpp asserts at line 335

331     if (!have) {
332       nsresult res = NS_OK;
334       nsCOMPtr<nsIFontPackageProxy> proxy = do_GetService("@mozilla.org/intl/fontpackageservice;1", &res);
335       NS_ASSERTION(NS_SUCCEEDED(res), "cannot get the font package proxy");
336       NS_ASSERTION(proxy, "cannot get the font package proxy");

I checked the //locale/nsLocaleDLL.cpp to see if the FontPackageService is registered.
The file doesn't contain FontPackageService anymore.  It has been accidently (?) removed by waterson
Bug 94831. Convert locale stuff to generic module. /r=ftang

I'll post a match to add the FontPackageService back.

(Assignee)

Comment 10

16 years ago
Created attachment 47913 [details] [diff] [review]
Redefining nsFontPackageService
(Assignee)

Comment 11

16 years ago
ftang/waterson: can you review and super review the patch?

Comment 12

16 years ago
read cvs log of mozilla/ intl/ locale/ src/ windows/ nsLocaleDLL.cpp (1.23)

1.23waterson%netscape.comAug 16 22:52 Bug 94831. Convert locale stuff to generic
module. r/sr=nobody: I am the devil.

r=ftang
Mr. devil (waterson), can you sr this one ? :)

Comment 13

16 years ago
sr=waterson. Do we need to do anything on Unix, OS/2, or Mac?
(Assignee)

Comment 14

16 years ago
waterson: >Do we need to do anything on Unix, OS/2, or Mac?
Not at the moment; however, we may want to support the font downloading 
for other platforms in near future. :)
(Assignee)

Comment 15

16 years ago
adding the topembed keyword. We need to check into 0_9_2_BRANCH tree.
Keywords: topembed
(Reporter)

Comment 16

16 years ago
I checked this in 8-30 0.9.2 build. This does not work in the build, either.
(Assignee)

Comment 17

16 years ago
checked into 0_9_2_BRANCH

Comment 18

16 years ago
Comment on attachment 47913 [details] [diff] [review]
Redefining nsFontPackageService

a=asa for checkin to the 0.9.4 branch
Attachment #47913 - Flags: approval+
(Assignee)

Comment 19

16 years ago
checked into 0_9_4_BRANCH and the trunk
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
(Reporter)

Comment 20

16 years ago
Verified as fixed in 09-06-0.9.2ec, 09-07-05-0.9.4 and 09-07-09 Win 32 trunk 
build.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.