963196 - Remove stats contributions from the marketplace

Status: RESOLVED WONTFIX

(Marketplace Graveyard :: Code Quality, defect, P3)

Description

[Andy McKay]

This might be a big bug. In the current architecture we create a stats contributions record in zamboni that contains information about the transaction that occurred. This was also done so that things like stats and refunds would work. Over time we've moved to a different architecture: refunds and transactions are stored in solitude, stats are done in monolith.

If we agree this is a good thing to do then we'll split of some sub bugs from this.

We still need stats contributions for AMO btw, so we can't drop the table.

Comment 1

[Rob Hudson [:robhudson]]

I use this table to match the solitude transaction ID to the contribution.addon so I know which revenue to tie the stat to which allows us to do per-app revenue charts. If we do remove this, would it be possible to track the app ID through solitude and into the logs?

Comment 2

[Allen Short [:ashort]]

Since stats contributions need to stay in AMO, this seems like a good thing to tackle post-split.

Comment 3

[Andy McKay]

(In reply to Rob Hudson [:robhudson] from comment #1)
> I use this table to match the solitude transaction ID to the
> contribution.addon so I know which revenue to tie the stat to which allows
> us to do per-app revenue charts. If we do remove this, would it be possible
> to track the app ID through solitude and into the logs?

I can't think of a simple way to do this without a table. Perhaps a simple table that contains transaction id, user and app. Last time I looked at stats.contributions, it contained a lot of stuff we don't need.

Comment 4

[Rob Hudson [:robhudson]]

(In reply to Andy McKay [:andym] from comment #3)
> I can't think of a simple way to do this without a table. Perhaps a simple
> table that contains transaction id, user and app. Last time I looked at
> stats.contributions, it contained a lot of stuff we don't need.

For stats, given a transaction ID from the solitude S3 logs I'm doing a separate query to zamboni to get the app ID and price_tier (USD). If there were any way that could be stored in the S3 log it'd remove the need for this and the Contributions table for stats.

See: https://github.com/mozilla/zamboni/blob/master/mkt/stats/api.py#L336

Comment 5

[Andy McKay]

When I can think of a good way to do this, I'll re-open.