If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Move title input from header into first save dialog and project editor

VERIFIED FIXED

Status

Webmaker
Popcorn Maker
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: thecount, Assigned: thecount)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Soon we're adding a publish and save button instead of just save.

I see people hitting save before adding a title all the time anyway, so we can move it into the first save, disable the save button until a title has been added, make the title input red, and also move the title input into the project editor.

Also consider it is not likely you need to change the project's title often.
(Assignee)

Updated

4 years ago
Assignee: nobody → scott
(Assignee)

Comment 1

4 years ago
Created attachment 8364731 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/429
Attachment #8364731 - Flags: review?(schranz.m)
Comment on attachment 8364731 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/429

Lint fails.

https://www.dropbox.com/s/qaz4zdpdfrda4f3/Screenshot%202014-01-24%2013.43.22.png Pretty sure we should move that preview button over. It looks pretty bad there not nestled up by the save button.

Now that the save button is always in that spot, maybe it makes sense to position the arrow in the middle of the button? https://www.dropbox.com/s/ss3vwr3igbnweez/Screenshot%202014-01-24%2013.57.56.png

Plus comments and stuff.
Attachment #8364731 - Flags: review?(schranz.m) → review-
(Assignee)

Comment 3

4 years ago
Comment on attachment 8364731 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/429

Updated
Attachment #8364731 - Flags: review- → review?(schranz.m)
Comment on attachment 8364731 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/429

Relatively small stuff. Looks like you missed my comments on UI in some places.
Attachment #8364731 - Flags: review?(schranz.m) → review-
(Assignee)

Comment 5

4 years ago
Comment on attachment 8364731 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/429

Updated.

I think I figured out what you wanted, cept I don't want them touching. I am open to it, but I don't see what's changed.

Also, the old way we did the arrows, I think, no longer works. I updated it to be a rotate instead of a weird hacked up border thingy.
Attachment #8364731 - Flags: review- → review?(schranz.m)
Comment on attachment 8364731 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/429

R+ with https://github.com/mozilla/popcorn.webmaker.org/pull/429/files#r9202104
Attachment #8364731 - Flags: review?(schranz.m) → review+
(Assignee)

Comment 7

4 years ago
Staged: https://github.com/mozilla/popcorn.webmaker.org/commit/fcbe08929b3b7143a8d9ab06e41a3d5be19a00ce

Needs verification.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Flags: needinfo?(scott)
Resolution: --- → FIXED
(Assignee)

Comment 8

4 years ago
This should go to the list of user facing changes.
Status: RESOLVED → VERIFIED
Flags: needinfo?(scott)
You need to log in before you can comment on or make changes to this bug.