Closed Bug 963274 Opened 6 years ago Closed 6 years ago

Make mozContacts.remove accept an ID

Categories

(Core Graveyard :: DOM: Contacts, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
1.4 S1 (14feb)

People

(Reporter: reuben, Assigned: reuben)

Details

(Whiteboard: [systemsfe])

Attachments

(1 file, 1 obsolete file)

See bug 929495.
Attachment #8364642 - Flags: review?(anygregor)
Comment on attachment 8364642 [details] [diff] [review]
Allow passing a contact ID to mozContacts.remove

Review of attachment 8364642 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/contacts/tests/test_contacts_basics2.html
@@ +807,5 @@
> +    req.onsuccess = function() {
> +      req = navigator.mozContacts.remove(c.id);
> +      req.onsuccess = function() {
> +        ok(true, "Successfully removed contact by ID");
> +        next();

Can we try to get it again to make sure it actually worked?
Attachment #8364642 - Flags: review?(anygregor) → review+
Carrying r=gwagner
Attachment #8364642 - Attachment is obsolete: true
Attachment #8367114 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/604c9742ffb4
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Whiteboard: [systemsfe]
Target Milestone: mozilla29 → 1.4 S1 (14feb)
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.