963373 - [AccessFu] Update cursor position after a scroll

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Eitan Isaacson [:eeejay]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/15661

When we scroll through a long screen, or homescreen pages with two fingers, the cursor should update to an item on the visible screen. The item should be the one closest to the previous cursor position.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Update cursor after scroll.

Comment 2

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8366260 [details] [diff] [review]
Update cursor after scroll.

Review of attachment 8366260 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with a slight change.

::: accessible/src/jsat/TraversalRules.jsm
@@ +28,5 @@
>    if (aRoles.indexOf(Roles.LABEL) < 0) {
>      this._matchRoles.push(Roles.LABEL);
>    }
>    this._matchFunc = aMatchFunc || function (acc) { return Filters.MATCH; };
> +  this.preFilter = aPreFilter ||

Lets take the default one out as a global variable similar to the gSimpleMatchFunc since we reuse it in Base and SimpleOnScreen.

Comment 3

[Eitan Isaacson [:eeejay]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/82937a8ffe75

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/82937a8ffe75