Closed Bug 963373 Opened 6 years ago Closed 6 years ago

[AccessFu] Update cursor position after a scroll

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: eeejay, Assigned: eeejay)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

When we scroll through a long screen, or homescreen pages with two fingers, the cursor should update to an item on the visible screen. The item should be the one closest to the previous cursor position.
Depends on: 964534
Comment on attachment 8366260 [details] [diff] [review]
Update cursor after scroll.

Review of attachment 8366260 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with a slight change.

::: accessible/src/jsat/TraversalRules.jsm
@@ +28,5 @@
>    if (aRoles.indexOf(Roles.LABEL) < 0) {
>      this._matchRoles.push(Roles.LABEL);
>    }
>    this._matchFunc = aMatchFunc || function (acc) { return Filters.MATCH; };
> +  this.preFilter = aPreFilter ||

Lets take the default one out as a global variable similar to the gSimpleMatchFunc since we reuse it in Base and SimpleOnScreen.
Attachment #8366260 - Flags: review?(yzenevich) → review+
https://hg.mozilla.org/mozilla-central/rev/82937a8ffe75
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.