If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Implement modal "Choose What To Sync" dialog

VERIFIED FIXED in mozilla29

Status

Cloud Services
Firefox Sync: UI
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: ttaubert, Assigned: ttaubert)

Tracking

unspecified
mozilla29
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa!])

Attachments

(2 attachments, 2 obsolete attachments)

Comment hidden (empty)
(Assignee)

Updated

4 years ago
Component: Server: Firefox Accounts → Firefox Sync: UI
QA Contact: jbonacci
Whiteboard: [qa+]
about:accounts hosted code is going to shoot over customizeSync: <true|false> in the account data during an account creation (not a login)

I'm hoping that will be useful. :)
(Assignee)

Comment 2

4 years ago
Created attachment 8366121 [details] [diff] [review]
0002-Bug-963384-Implement-modal-Choose-What-To-Sync-dialo.patch
Attachment #8366121 - Flags: review?(mhammond)
(Assignee)

Comment 3

4 years ago
Created attachment 8366126 [details] [diff] [review]
0002-Bug-963384-Implement-modal-Choose-What-To-Sync-dialo.patch, v2

Small fixes.
Attachment #8366121 - Attachment is obsolete: true
Attachment #8366121 - Flags: review?(mhammond)
Attachment #8366126 - Flags: review?(mhammond)
Blocks: 964920
(Assignee)

Comment 4

4 years ago
Created attachment 8367000 [details] [diff] [review]
0001-Bug-963384-Implement-modal-Choose-What-To-Sync-dialo.patch, v3

String updates and moved the clearUserPref() call to Weave.js.
Attachment #8366126 - Attachment is obsolete: true
Attachment #8366126 - Flags: review?(mhammond)
Attachment #8367000 - Flags: review?(mhammond)
Comment on attachment 8367000 [details] [diff] [review]
0001-Bug-963384-Implement-modal-Choose-What-To-Sync-dialo.patch, v3

couple of comments from a quick skim:
- worth adding a comment in syncCustomize.dtd referencing about other similar strings elsewhere
- should make sure our references to "Preferences" are correct across platforms (Options vs. Preferences)
(Assignee)

Comment 6

4 years ago
Created attachment 8367083 [details] [diff] [review]
0001-Bug-963384-Implement-modal-Choose-What-To-Sync-dialo.patch, v4

Addressed Gavin's comments.
Attachment #8367000 - Attachment is obsolete: true
Attachment #8367000 - Flags: review?(mhammond)
Attachment #8367083 - Flags: review?(mhammond)
Comment on attachment 8367000 [details] [diff] [review]
0001-Bug-963384-Implement-modal-Choose-What-To-Sync-dialo.patch, v3

Review of attachment 8367000 [details] [diff] [review]:
-----------------------------------------------------------------

Some comments in the dtd about the duplicate strings would be good.

::: browser/base/content/sync/customize.js
@@ +5,5 @@
> +"use strict";
> +
> +addEventListener("dialogaccept", function () {
> +  window.arguments[0].accepted = true;
> +});

personally I'd be happy with an ondialogaccept attribute in the xul file, but it's up to you...
Attachment #8367000 - Attachment is obsolete: false

Updated

4 years ago
Attachment #8367083 - Flags: review?(mhammond) → review+
(Assignee)

Comment 8

4 years ago
https://hg.mozilla.org/integration/fx-team/rev/f91e0b1cc148
https://hg.mozilla.org/integration/fx-team/rev/73ed67830408

Comment 9

4 years ago
https://hg.mozilla.org/mozilla-central/rev/f91e0b1cc148
https://hg.mozilla.org/mozilla-central/rev/73ed67830408
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Verified using the following environment:

FF 29.0b8
Build Id: 20140414143035
OS: Win 7 x64, Mac Os x 10.9.2, Ubuntu 13.04 x 64 

No modal dialog appeared to choose what to sync, not when a new sync account was created and not when logging using an already created account. If I'm missing something please provide the required information to verify this bug.

From my point of view this bug is not fixed.
Flags: needinfo?(ttaubert)
On the first testing I somehow missed "Choose what to sync" checkbox when creating a new account.

Verified using the following environment:

FF 29.0b8
Build Id: 20140414143035
OS: Win 7 x64, Mac Os x 10.9.2, Ubuntu 13.04 x 64 

After selecting "Choose what to sync" checkbox  when you verify your email from Firefox an modal window is prompted.
Status: RESOLVED → VERIFIED
Flags: needinfo?(ttaubert)
Whiteboard: [qa+] → [qa!]
You need to log in before you can comment on or make changes to this bug.