963401 - Console is flooded with javascript strict warnings

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Description

[felix.shnir]

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/32.0.1700.76 Safari/537.36

Steps to reproduce:

Started a new addon via cfx init.
Ran it with cfx run


Actual results:

Console is flooded with javascript strict warnings unrelated to the addon


Expected results:

Console should have been empty

Comment 1

[felix.shnir]

Its fixed if the sdk\python-lib\cuddlefish\prefs.py "javascript.options.strict" option is set to False.

In the mean time I've added a note in the Logging section of the docs. Please remove if this is addressed in another way: https://developer.mozilla.org/en-US/Add-ons/SDK/Tutorials/Logging

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

Can we remove this pref? If not for cfx, for JPM? I know I find it annoying/difficult when debugging a page-mod and loading a page greets me with a giant dump of useless warnings about code that isn't mine.

Comment 3

[Dave Townsend [:mossop]]

I think we should but I'm open to Irakli saying otherwise

Comment 4

[Jeff Griffiths (:canuckistani) (:⚡︎)]

I agree, seeing the JS warnings is distracting, +1 for removing from JPM. I don't see a pull request that removes it from cfx, so I guess we're not going to do anything for 1.16.

Comment 5

[Tomislav Jovanovic :zombie]

Attachment: Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1372

(In reply to Jeff Griffiths (:canuckistani) from comment #4)
> I don't see a pull request that removes it from cfx, so I guess we're 
> not going to do anything for 1.16.

i have been responding to #jetpack questions about this regularly in the last few months, so if this is a "go", i would really like it to be in 1.16 too..

Comment 6

[Jeff Griffiths (:canuckistani) (:⚡︎)]

(In reply to Tomislav Jovanovic [:zombie] from comment #5)
> i have been responding to #jetpack questions about this regularly in the
> last few months, so if this is a "go", i would really like it to be in 1.16
> too..

I hear you and I think would agree, if we had a patch. Oh wait, we do!

Comment 7

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8369097 [details] [review]
Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1372

I'm r+ing Zombie's PR, but waiting for Irakli's thumbs up to merge this in. Jeff, is this too late to get in 1.16?

Comment 8

[Jordan Santell [:jsantell] [@jsantell]]

Approved in meeting today

Comment 9

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/319ce7bf0b13cddf9768cef1be0386940ba45065
bug 963401 - remove javascript.option.strict pref

https://github.com/mozilla/addon-sdk/commit/c88f1c2e8a28c364700270bbc3f1c92fc82be813
Merge pull request #1372 from zombie/963401-js-strict

fix bug 963401 - remove javascript.option.strict pref, r=@jsantell