Closed Bug 963403 Opened 6 years ago Closed 6 years ago

[clock] build: make_gaia_shared.js should use source dir for shared dependency scanning

Categories

(Firefox OS Graveyard :: Gaia::Clock, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
1.3 C3/1.4 S3(31jan)

People

(Reporter: jrburke, Assigned: jrburke)

Details

(Whiteboard: [p=1])

Attachments

(1 file)

46 bytes, text/x-github-pull-request
mcav
: review+
Details | Review
Related to bug 962969:

If clock decides to uglify files, it is best to use the source directory to scan for shared resources. I will attach a patch that is similar to the one for email, but for clock's make_gaia_shared.js
Attached file GitHub pull request
Same sort of change as email. Tested on device, clock still works.
Attachment #8364831 - Flags: review?(m)
Comment on attachment 8364831 [details] [review]
GitHub pull request

Cool, thanks!
Attachment #8364831 - Flags: review?(m) → review+
Merged gaia master:
https://github.com/mozilla-b2g/gaia/commit/4699d2378ec81d27dfc8fe40083f5b2944676d90

from pull request:
https://github.com/mozilla-b2g/gaia/pull/15665
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [p=1]
You need to log in before you can comment on or make changes to this bug.