963458 - [Media Encoder][b2g-emulator-jb] Cannot record the video stream from fake gUM

Status: RESOLVED FIXED

(Core :: Audio/Video: Recording, defect)

Description

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

STR. on emulator-jb, git gecko ver:85b8bb0ff931e
1. get media stream from fake getUserMedia
2. record the media stream
3. got onerror callback

log: 
I/OMXClient(  535): Using client-side OMX mux.
I/SoftAVCEncoder(  535): Construct SoftAVCEncoder
I/ACodec  (  535): setupVideoEncoder succeeded
E/ACodec  (  535): [OMX.google.h264.encoder] configureCodec returning error -2147483648
E/MediaCodec(  535): Codec reported an error. (omx error 0x80001001, internalError -2147483648)
I/MediaEncoder(  535): [VideoTrackEncoder]: Fail to initialize the encoder!
I/OMXClient(  535): Using client-side OMX mux.
I/MediaEncoder(  535): [AudioTrackEncoder]: Receive TRACK_EVENT_ENDED .

Comment 1

[John Lin [:jhlin][:jolin]]

SoftAVCEncoder does not support encoding video resolution > CIF (352x288) (See http://androidxref.com/4.3_r2.1/xref/frameworks/av/media/libstagefright/codecs/avc/enc/SoftAVCEncoder.cpp#60). Need to use different AVC/H.264 encoder configuration if running on emulator.

Comment 2

[John Lin [:jhlin][:jolin]]

Incorrectly set QA Contact field in previous editing.

Comment 3

[John Lin [:jhlin][:jolin]]

Attachment: avc-encoder-config-for-emu.patch

Use Android system properties API to check if we're running on emulator and adjust parameters accordingly.

Comment 4

[John Lin [:jhlin][:jolin]]

Attachment: avc-encoder-config-for-emu.patch

Return error rather than assert/crash when input size too large. (Thanks to feedback from :CJKu and :rlin)

Comment 5

[u459114]

Comment on attachment 8375415 [details] [diff] [review]
avc-encoder-config-for-emu.patch

Review of attachment 8375415 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/omx/OMXCodecWrapper.cpp
@@ +132,5 @@
> +  OMX_VIDEO_CONTROLRATETYPE bitrateMode = OMX_Video_ControlRateConstant;
> +  // Limitation of soft AVC/H.264 encoder running on emulator in stagefright.
> +  static bool emu = IsRunningOnEmulator();
> +  if (emu) {
> +    if (aWidth > 352 || aHeight > 288) {

If software encoder in stagefright can accept VGA resolution in future, code here will block recording pipeline forever.

Another suggestion is instead of return NS_ERROR_INVALID_ARG here, you may 
if (aWidth > 352 || aHeight > 288) {
  mMayFailedBecauseOfResolutionToBig = true;
}

After getting an unknown error callback from MediaCodec, in error callback function, write this log:
CODEC_ERROR("SoftAVCEncoder doesn't support resolution larger than CIF");

Comment 6

[John Lin [:jhlin][:jolin]]

Attachment: Change AVC/H.264 encoder configuration for B2G emulator

Update commit message & carry r+ from roc.

Comment 7

[John Lin [:jhlin][:jolin]]

try result: https://tbpl.mozilla.org/?tree=Try&rev=6b6d2bb2aad1

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/4dcf54ce26cc

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4dcf54ce26cc