Closed Bug 963476 Opened 12 years ago Closed 12 years ago

Use a more internationally friendly collection for everything.me collection test

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::UI Tests
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: davehunt, Assigned: davehunt)

Details

Attachments

(1 file)

Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/15676
46 bytes, text/x-github-pull-request
Bebe
: review+
AndreiH
: review+
Details | Review
Currently the test uses 'Autos', which fails for me in the UK because it's called 'Cars' here. We should look into fixing this to a specific locale, or using a collection that does not vary, such as 'Books'.
This passes for me locally, but I see that the adhoc job had a failure
Yeah, turns out 'Books' does not appear in the US-centric list. Updated the pull to use 'Local', which does appear in both. Triggered a new adhoc build: http://qa-selenium.mv.mozilla.com:8080/view/B2G%20Hamachi/job/b2g.hamachi.mozilla-central.ui.adhoc/118/
Attachment #8364940 - Flags: review+
Comment on attachment 8364940 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/15676 We don't have a "Local" entry in the collections menu. The test fails locally for me
Attachment #8364940 - Flags: review?(florin.strugariu) → review-
Could you please provide a screenshot or list of collections that you see? I tried to work out how Everything.me determines location, but cannot. As far as I can tell it's not using navigator.locale, timezone settings, or geolocation. I suppose it could be something server-side. Let's see if we can find a common collection. :)
Ran: Do you know if we can trick Everything.me into using a specified locale so our tests are consistent no matter where they are executed?
Flags: needinfo?(ran)
On my hamachi I see the fallowing options: [u'Custom\u2026', u'Answers', u'Around Me', u'Arts & Crafts', u'Astrology', u'Autos', u'Baseball', u'Basketball', u'Beauty', u'Books', u'Business Services', u'Buzz', u'Celebs', u'City Guides', u'Classifieds', u'Comics', u'Culture', u'DIY', u'Daily Deals', u'Dating', u'Directory Services', u'Electronics', u'Email', u'Environment', u'Extreme Sports', u'Fashion', u'Financial News', u'Financial Services', u'Fitness & Wellbeing', u'Flights', u'Football', u'For Kids', u'Funny', u'Gifts', u'Google', u'Groceries', u'Health & Medical', u'History', u'Hockey', u'Hotels', u"I'm So Bored", u'Images', u'Internet', u'Jobs', u'LGBT', u'Learning & Education', u'Lifestyle', u'Movies', u'News', u'Nightlife', u'Outdoor Activities', u'Personal Communication', u'Personalization', u'Pets', u'Photography', u'Politics', u'Productivity', u'Radio', u'Real Estate', u'Recipes', u'Reference', u'Religion', u'Restaurants', u'Science', u'Shipping Services', u'Shoes', u'Shopping', u'Soccer', u'Sports', u'TV', u'Tech', u'Tech Conference', u'Telecommunication', u'Tennis', u'Theater', u'Toys', u'Transportation', u'Travel', u'Travel Guides', u'Utilities', u"Valentine's Day", u'Video', u'Video Games', u'Weather', u'Weddings']
Interesting, so for you it looks like 'Local' is 'Around Me'. Here's my list: [u'Custom\u2026', u'Local', u'Arts & Crafts', u'Astrology', u'Beauty', u'Books', u'Business Services', u'Buzz', u'Autos', u'Celebs', u'City Guides', u'Classifieds', u'Culture', u'Daily Deals', u'Dating', u'Directory Services', u'Electronics', u'Email', u'Fashion', u'Financial News', u'Financial Services', u'Fitness', u'Flights', u'Flowers', u'Football', u'For Kids', u'Funny', u'Gifts', u'Groceries', u'Health', u'History', u'Hotels', u"I'm So Bored", u'Jobs', u'LGBT', u'Learning & Education', u'Lifestyle', u'Maps', u'Movies', u'News', u'Nightlife', u'Outdoor Activities', u'Parenting', u'Personal Communication', u'Personalization', u'Pets', u'Politics', u'Productivity', u'Property', u'Radio', u'Recipes', u'Reference', u'Restaurants', u'Rugby', u'Science', u'Shipping Services', u'Shoes', u'Shopping', u'Sports', u'TV', u'Tech News', u'Tech Conference', u'Telecommunication', u'Theatre', u'Top Apps', u'Toys', u'Transportation', u'Travel', u'Travel Guides', u'Video', u'Video Games', u'Weather', u'Weddings']
Comment on attachment 8364940 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/15676 Weather work for me, and MV [1]. Can you test this Bebe? [1] http://qa-selenium.mv.mozilla.com:8080/view/B2G Hamachi/job/b2g.hamachi.mozilla-central.ui.adhoc/119
Attachment #8364940 - Flags: review- → review?(florin.strugariu)
(In reply to Dave Hunt (:davehunt) from comment #7) > Ran: Do you know if we can trick Everything.me into using a specified locale > so our tests are consistent no matter where they are executed? Hi Dave. It is currently not possible to programmatically set the location reported to Everything.me API. Let me suggest the following alternatives: 1. use location spoofing when running the tests. Or, 2. change the test so that the Collection name is not hard-coded into the test: (a) choose the first suggestion and save it's label. (b) assert the label is installed on the homescreen.
Flags: needinfo?(ran)
(In reply to Amir Nissim (Everything.me) from comment #11) > (In reply to Dave Hunt (:davehunt) from comment #7) > > Ran: Do you know if we can trick Everything.me into using a specified locale > > so our tests are consistent no matter where they are executed? > > Hi Dave. > > It is currently not possible to programmatically set the location reported > to Everything.me API. > > Let me suggest the following alternatives: > 1. use location spoofing when running the tests. Or, This is what I was suggesting too, but I'm not able to determine how Everything.me determines location. We would need this information before we can consider how to spoof it. > 2. change the test so that the Collection name is not hard-coded into the > test: (a) choose the first suggestion and save it's label. (b) assert the > label is installed on the homescreen. Unfortunately the collection names that appear in the list do not always match those added to the homescreen. For example Autos/Cars and Local/Around Me, otherwise I suspect we would have already used this approach.
(In reply to Dave Hunt (:davehunt) from comment #12) > Unfortunately the collection names that appear in the list do not always > match those added to the homescreen. For example Autos/Cars and Local/Around > Me, otherwise I suspect we would have already used this approach. This is kind of a bug, in that E.me should cache localised names rather than just US ones. (if I understand correctly the labels come from a cache).
Comment on attachment 8364940 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/15676 Weather works for me 2. Let's go with weather
Attachment #8364940 - Flags: review?(florin.strugariu) → review+
Weather is ubiqutous :)
Merged in https://github.com/mozilla-b2g/gaia/commit/1109a40e744e7b47515f1c65e66f3fb81bd860fb
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
(In reply to Dave Hunt (:davehunt) from comment #12) > > This is what I was suggesting too, but I'm not able to determine how > Everything.me determines location. We would need this information before we > can consider how to spoof it. We are using navigator.geolocation.getCurrentPosition: https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/everything.me/modules/Location/Location.js#L38 > Unfortunately the collection names that appear in the list do not always > match those added to the homescreen. For example Autos/Cars and Local/Around > Me, otherwise I suspect we would have already used this approach. This is a bug! I filed bug #964215 and will fix it later today. Thanks!
(In reply to Dave Hunt (:davehunt) from comment #12) > This is what I was suggesting too, but I'm not able to determine how > Everything.me determines location. We would need this information before we > can consider how to spoof it. FYI - a fix landed in master. Might want to change the test and remove the hard coded collection name. Thanks Dave.
Sorry, I was referring to: (In reply to Dave Hunt (:davehunt) from comment #12) > Unfortunately the collection names that appear in the list do not always > match those added to the homescreen. For example Autos/Cars and Local/Around > Me, otherwise I suspect we would have already used this approach. #makecommentediatble
(In reply to Amir Nissim (Everything.me) from comment #19) > Sorry, I was referring to: > > (In reply to Dave Hunt (:davehunt) from comment #12) > > Unfortunately the collection names that appear in the list do not always > > match those added to the homescreen. For example Autos/Cars and Local/Around > > Me, otherwise I suspect we would have already used this approach. > > #makecommentediatble Heh, thanks! I agree that making this test less hard-coded would be good. I'll raise a bug for it.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: