963486 - [OPP] Sender should show transfer progress bar after receiver accepts

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Ben Tian (inactive)]

Gecko should trigger gaia to show transfer progress bar AFTER receiver accepts, instead of BEFORE it.

Comment 1

[Ben Tian (inactive)]

Attachment: Patch 1 (v1): Trigger gaia to show progress bar after receiver accepts

Comment 2

[Eric Chou [:ericchou] [:echou]]

Comment on attachment 8364962 [details] [diff] [review]
Patch 1 (v1): Trigger gaia to show progress bar after receiver accepts

Delegate to Gina.

Comment 3

[Gina Yeh [:gyeh] [:ginayeh]]

Comment on attachment 8364962 [details] [diff] [review]
Patch 1 (v1): Trigger gaia to show progress bar after receiver accepts

Review of attachment 8364962 [details] [diff] [review]:
-----------------------------------------------------------------

I like the idea that broadcast the system message when the first PUT packet is sent since that's when a file transfer is actually started. However, I have some concerns. Once if we failed before sending out the first PUT packet, no progress bar is shown and no hint for users that the transfer is failed somehow. Is it what we expected?

::: dom/bluetooth/bluedroid/BluetoothOppManager.cpp
@@ +1471,5 @@
> +      FileTransferComplete();
> +    } else {
> +      if (!mSentFileLength) {
> +        StartFileTransfer();
> +      }

Question: Is there any cases where we need to call function StartFileTransfer() here? Did I miss anything important?

Think about the following scenario: when the file name exceeds maximum length, a disconnect request is sent and then the socket is disconnected. In this case, |mSentFileLength| is still 0 and two system messages are broadcasted afterwards. As a result, the progress bar is still triggered even if no PUT packet is sent. It's kinda different from what we expected for this patch, right?

Comment 4

[Gina Yeh [:gyeh] [:ginayeh]]

I'd like to get some input from our UX, Neo.

Neo, can you answer my question? Thanks.

(In reply to Gina Yeh [:gyeh] [:ginayeh] from comment #3)
> 
> Once if we failed before sending out the first PUT
> packet, no progress bar is shown and no hint for users that the transfer is
> failed somehow. Is it what we expected?
>

Comment 5

[Neo Hsieh [:neo]]

Hi Gina, I remembered any error of BT transferring will show toast message and notification to inform user. Is that not including you mentioned ?

Comment 6

[Gina Yeh [:gyeh] [:ginayeh]]

I'm afraid that this case is not handled after applying the change. Per discussion with Neo, we should show toast message and notification to inform user in this cases.

I propose to send another message for connection status. Let me discuss with Ben later.

Comment 7

[Ben Tian (inactive)]

(In reply to Gina Yeh [:gyeh] [:ginayeh] from comment #3)
> Comment on attachment 8364962 [details] [diff] [review]
> Patch 1 (v1): Trigger gaia to show progress bar after receiver accepts
> 
> Review of attachment 8364962 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I like the idea that broadcast the system message when the first PUT packet
> is sent since that's when a file transfer is actually started. However, I
> have some concerns. Once if we failed before sending out the first PUT
> packet, no progress bar is shown and no hint for users that the transfer is
> failed somehow. Is it what we expected?
This is what the following part of code to solve.

> ::: dom/bluetooth/bluedroid/BluetoothOppManager.cpp
> @@ +1471,5 @@
> > +      FileTransferComplete();
> > +    } else {
> > +      if (!mSentFileLength) {
> > +        StartFileTransfer();
> > +      }
> 
> Question: Is there any cases where we need to call function
> StartFileTransfer() here? Did I miss anything important?
> 
> Think about the following scenario: when the file name exceeds maximum
> length, a disconnect request is sent and then the socket is disconnected. In
> this case, |mSentFileLength| is still 0 and two system messages are
> broadcasted afterwards. As a result, the progress bar is still triggered
> even if no PUT packet is sent. It's kinda different from what we expected
> for this patch, right?
Yes. In this case mSuccessFlag is false (set in AfterOppConnected()=>AfterFirstPut()), and we sends both start and complete system messages to inform gaia of failure; on the other hand, if we fail after receiver's confirmation (|mSentFileLength| > 0), we only send complete system message for failure notification.

Comment 8

[Gina Yeh [:gyeh] [:ginayeh]]

Comment on attachment 8364962 [details] [diff] [review]
Patch 1 (v1): Trigger gaia to show progress bar after receiver accepts

Review of attachment 8364962 [details] [diff] [review]:
-----------------------------------------------------------------

We need to handle the case I mentioned before and I'd like to see the patch again.

Comment 9

[Ben Tian (inactive)]

De-assign myself since I'm not actively working on this bug.

Comment 10

[BMO Automation]

Firefox OS is not being worked on